Fix 5442338: Return true if the pc descriptor verifier skips verification because of too many des...

runtime/vm/code_generator_ia32.cc

Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc	(revision 464)
+++ runtime/vm/code_generator_ia32.cc	(working copy)
@@ -356,12 +356,12 @@
 #if defined(DEBUG)
   // TODO(srdjan): Implement a more efficient way to check, currently drop
   // the check for too large number of descriptors.
-  if (descriptors.Length() > 1000) {
+  if (descriptors.Length() > 3000) {
     if (FLAG_trace_compiler) {
       OS::Print("Not checking pc decriptors, length %d\n",
                 descriptors.Length());
     }
-    return false;
+    return true;

[ngeoffray, 2011/10/17 12:19:04]

Do you actually need the return now that the method always returns true? Will
you improve the method in a way that you know will return false?

[srdjan, 2011/10/17 12:23:48]

Remove return, use ASSERTS as already implemented.

   }
   for (intptr_t i = 0; i < descriptors.Length(); i++) {
     intptr_t pc = descriptors.PC(i);
@@ -394,10 +394,7 @@
       pc_descriptors_list_->FinalizePcDescriptors(code.EntryPoint()));
   bool ok = VerifyPcDescriptors(
       descriptors, parsed_function_.function().is_optimizable());
-  if (!ok) {
-    // TODO(5442338) Fix bad pc descriptor generation.
-    parsed_function_.function().set_is_optimizable(false);
-  }
+  ASSERT(ok);
   code.set_pc_descriptors(descriptors);
 }