Issue 8318001: Adding `content_security_policy` to a few sample extensions

Issue 8318001: Adding `content_security_policy` to a few sample extensions (Closed)

Created:
9 years, 2 months ago by Mike West

Modified:
8 years, 11 months ago

Reviewers:
Use mkwst_at_chromium.org plz., Boris Smus, abarth-chromium

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Adding `content_security_policy` to 5 sample extensions Touched: * tabs/screenshot * webNavigation/basic * windows/merge_windows * browserAction/make_page_red * extensions/ttsdebug BUG=92644 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107094

Patch Set 1 #

Patch Set 2 : webNavigation/basic #

Patch Set 3 : windows/merge_windows #

Patch Set 4 : browserAction/make_page_red #

Patch Set 5 : extensions/ttsdebug #

Patch Set 6 : processes/show_tabs #

Total comments: 7

Patch Set 7 : Docs. Zips. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+464 lines, -433 lines)			Patch
M	chrome/common/extensions/docs/examples/api/browserAction/make_page_red.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.html	View	1 2 3	1 chunk	+7 lines, -17 lines	0 comments	Download
A	chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.js	View	1 2 3	1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/browserAction/make_page_red/manifest.json	View	1 2 3	1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/omnibox/extension-docs.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/processes/show_tabs.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/processes/show_tabs/manifest.json	View	1 2 3 4 5	1 chunk	+3 lines, -2 lines	0 comments	Download
A	chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.css	View	1 2 3 4 5	1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.html	View	1 2 3 4 5	1 chunk	+10 lines, -90 lines	0 comments	Download
A	chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.js	View	1 2 3 4 5	1 chunk	+69 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/tabs/screenshot.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/tabs/screenshot/background.html	View		1 chunk	+1 line, -3 lines	0 comments	Download
A +	chrome/common/extensions/docs/examples/api/tabs/screenshot/background.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/tabs/screenshot/manifest.json	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/tabs/screenshot/screenshot.html	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/tabs/screenshot/screenshot.js	View		1 chunk	+2 lines, -51 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/webNavigation/basic.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/webNavigation/basic/background.html	View	1	1 chunk	+2 lines, -17 lines	0 comments	Download
A	chrome/common/extensions/docs/examples/api/webNavigation/basic/background.js	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/webNavigation/basic/manifest.json	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
A	chrome/common/extensions/docs/examples/api/webNavigation/basic/popup.css	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/webNavigation/basic/popup.html	View	1	1 chunk	+2 lines, -88 lines	0 comments	Download
A	chrome/common/extensions/docs/examples/api/webNavigation/basic/popup.js	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/windows/merge_windows.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/windows/merge_windows/background.html	View	1 2	1 chunk	+6 lines, -46 lines	0 comments	Download
A	chrome/common/extensions/docs/examples/api/windows/merge_windows/background.js	View	1 2	1 chunk	+45 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/windows/merge_windows/manifest.json	View	1 2	1 chunk	+15 lines, -14 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/extensions/app_launcher.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/extensions/ttsdebug.zip	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/extensions/ttsdebug/manifest.json	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
A	chrome/common/extensions/docs/examples/extensions/ttsdebug/ttsdebug.css	View	1 2 3 4	1 chunk	+64 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/extensions/ttsdebug/ttsdebug.html	View	1 2 3 4	1 chunk	+28 lines, -90 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/extensions/ttsdebug/ttsdebug.js	View	1 2 3 4	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.html	View	1 2 3 4 5 6	6 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1 2 3 4 5 6	9 chunks	+23 lines, -12 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Use mkwst_at_chromium.org plz.

Five seems like a good number. :) These were all more or less trivial; no ...

9 years, 2 months ago (2011-10-17 15:09:17 UTC) #1

Boris Smus

LGTM with a few nits. http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.html File chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.html (right): http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.html#newcode1 chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.html:1: <!doctype html> woo http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/docs/examples/api/processes/show_tabs/manifest.json ...

9 years, 2 months ago (2011-10-18 21:42:06 UTC) #2

Mike West

I'll ping you about these this evening; I don't really understand some of the points ...

9 years, 2 months ago (2011-10-19 08:39:12 UTC) #3

I'll ping you about these this evening; I don't really understand some of the
points you made. :)

http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/doc...
File
chrome/common/extensions/docs/examples/api/processes/show_tabs/manifest.json
(right):

http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/processes/show_tabs/manifest.json:6:
"experimental", "tabs", "chrome://favicon/*"
On 2011/10/18 21:42:06, Boris Smus wrote:
> Why do we need this?

Because the extension displays favicons for each item in it's list. Unless we
explicitly whitelist `chrome://favicon` in the extension's permissions, then the
extension can't load images from the origin.

http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/tabs/screenshot/manifest.json
(right):

http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/tabs/screenshot/manifest.json:11:
"content_security_policy": "default-src 'none'; script-src 'self'; img-src
data:"
On 2011/10/18 21:42:06, Boris Smus wrote:
> Cool, just read about this! One concern is that the spec will change to remove
> some of these features. Thoughts?

I don't think that's likely (maybe I'm misunderstanding your question?). Script
and images are relatively critical aspects of websites; I don't think the spec
would remove the ability to whitelist them.

http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/doc...
File
chrome/common/extensions/docs/examples/api/windows/merge_windows/background.html
(right):

http://codereview.chromium.org/8318001/diff/6001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/windows/merge_windows/background.html:8:
</body>
On 2011/10/18 21:42:06, Boris Smus wrote:
> According to http://html5.validator.nu/, body element is necessary to
validate.

Ok... there's a body element. I'm not sure I understand the nit here. :)

> Which validator do you use?

None, as of yet. :)

Mike West

I'll ping you about these this evening; I don't really understand some of the points ...

9 years, 2 months ago (2011-10-19 08:39:35 UTC) #4

Mike West

On 2011/10/19 08:39:35, Mike West (chromium) wrote: > I'll ping you about these this evening; ...

9 years, 2 months ago (2011-10-25 10:29:33 UTC) #5

Speeddymon

One nit I have (new to writing extensions but not to coding) is the decision ...

8 years, 11 months ago (2012-01-28 07:30:18 UTC) #6

Answered per email.

Expand Messages | Collapse Messages