Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5696)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome_frame/chrome_tab.cc

Issue 8317018: Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a global... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome_frame/chrome_frame_launcher.gyp ('K') | « chrome_frame/chrome_protocol.h ('k') | chrome_frame/delete_chrome_history.h » ('j') | chrome_frame/iids.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_tab.cc
===================================================================
--- chrome_frame/chrome_tab.cc (revision 105823)
+++ chrome_frame/chrome_tab.cc (working copy)
@@ -4,8 +4,8 @@
// chrome_tab.cc : Implementation of DLL Exports.
-// Include without path to make GYP build see it.
-#include "chrome_tab.h" // NOLINT
+// Need to include this before the ATL headers below.
+#include "chrome_frame/chrome_tab.h"
grt (UTC plus 2) 2011/10/18 15:56:24 should this still have // NOLINT since it appears
robertshield 2011/10/18 17:31:10 It would appear not.
#include <atlsecurity.h>
#include <objbase.h>
« chrome_frame/chrome_frame_launcher.gyp ('K') | « chrome_frame/chrome_protocol.h ('k') | chrome_frame/delete_chrome_history.h » ('j') | chrome_frame/iids.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698