Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8316004: Update DEPS so that only browser directories can access content public API for browser. (Closed)

Created:
9 years, 2 months ago by jam
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Update DEPS so that only browser directories can access content public API for browser. TBR=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105884

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/DEPS View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/DEPS View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years, 2 months ago (2011-10-17 17:07:31 UTC) #1
jam
doh, I can't actually commit this since I get the following checkdeps errors. Can you ...
9 years, 2 months ago (2011-10-17 17:08:14 UTC) #2
jam
ok actually Ben, can you take a look at this? I added exceptions just for ...
9 years, 2 months ago (2011-10-17 17:25:59 UTC) #3
Ben Goodger (Google)
9 years, 2 months ago (2011-10-17 20:56:36 UTC) #4
i will look tomorrow, ooo today in san mateo.

-Ben

On Mon, Oct 17, 2011 at 10:25 AM, <jam@chromium.org> wrote:

> ok actually Ben, can you take a look at this? I added exceptions just for
> native_web_keyboard_event.h so that we don't have any more regressions.
> perhaps
> this file needs to be moved to content\public\common?
>
>
http://codereview.chromium.**org/8316004/<http://codereview.chromium.org/8316...
>

Powered by Google App Engine
This is Rietveld 408576698