97871: Bottom half of new tab button on tabstrip is not touchable.

97871: Bottom half of new tab button on tabstrip is not touchable.
new-tab button hit rect doesnt extend to the bottom of the button.  The touchable part of this +
button is only the top half of it. Touches at the bottom half of the button do not register.
Since the newtab button bitmap is different for touch and non-touch paths, the custom points
should be updated for touch_ui path as per bitmap.

BUG=97871
TEST=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106377

[Ravi Kasibhatla, 2011-10-17 11:33:51]

Patch for fixing the issue reported in 97871

[pkotwicz, 2011-10-17 14:08:42]

Tested patch on TOUCH_UI in chrome and chromeos and the hit area is correct with
this patch. Haven't validated against the image file though.

[Emmanuel Saint-loubert-Bié, 2011-10-17 15:28:11]

chrome/browser/ui/views/tabs/tab_strip.cc LGTM

[Emmanuel Saint-loubert-Bié, 2011-10-17 16:58:51]

Just to clear I cannot give an LGTM on AUTHORS because I am not sure how this
works. Therefore you have to have someone with authority over that file give you
an LGTM before you can commit.

[Ravi Kasibhatla, 2011-10-17 17:33:01]

On 2011/10/17 16:58:51, Emmanuel Saint-loubert wrote:
> Just to clear I cannot give an LGTM on AUTHORS because I am not sure how this
> works. Therefore you have to have someone with authority over that file give
you
> an LGTM before you can commit.
Adding jam as I am not sure who is the correct authority for AUTHORS file. :)

[tony, 2011-10-17 17:39:09]

http://codereview.chromium.org/8316001/diff/1/AUTHORS
File AUTHORS (right):

http://codereview.chromium.org/8316001/diff/1/AUTHORS#newcode138
AUTHORS:138: Ravi Phaneendra Kasibhatla <nvmw86@motorola.com>
This is not the email address you used to sign the CLA.  The cla has
ravi.kasibhatla@motorola.com.

[Ravi Kasibhatla, 2011-10-17 17:52:28]

On 2011/10/17 17:39:09, tony wrote:
> http://codereview.chromium.org/8316001/diff/1/AUTHORS
> File AUTHORS (right):
> 
> http://codereview.chromium.org/8316001/diff/1/AUTHORS#newcode138
> AUTHORS:138: Ravi Phaneendra Kasibhatla <mailto:nvmw86@motorola.com>
> This is not the email address you used to sign the CLA.  The cla has
> mailto:ravi.kasibhatla@motorola.com.
Hi Tony,
ravi.kasibhatla@motorola.com is an friendly alias for nvmw86@motorola.com (both
official mail address though). Should I sign CLA again using
nvmw86@motorola.com?

[tony, 2011-10-17 18:00:00]

On 2011/10/17 17:52:28, nvmw86 wrote:
> Hi Tony,
> mailto:ravi.kasibhatla@motorola.com is an friendly alias for
mailto:nvmw86@motorola.com (both
> official mail address though). Should I sign CLA again using
> nvmw86@motorola.com?

Yes.  Alternately, you can put ravi.kasibhatla@motorola.com in the AUTHORS file.

[Ravi Kasibhatla, 2011-10-17 18:36:02]

On 2011/10/17 18:00:00, tony wrote:
> On 2011/10/17 17:52:28, nvmw86 wrote:
> > Hi Tony,
> > mailto:ravi.kasibhatla@motorola.com is an friendly alias for
> mailto:nvmw86@motorola.com (both
> > official mail address though). Should I sign CLA again using
> > nvmw86@motorola.com?
> 
> Yes.  Alternately, you can put mailto:ravi.kasibhatla@motorola.com in the
AUTHORS file.
Ok. I will update the patch and upload the corrected one.

[jam, 2011-10-17 22:23:23]

On 2011/10/17 17:33:01, nvmw86 wrote:
> On 2011/10/17 16:58:51, Emmanuel Saint-loubert wrote:
> > Just to clear I cannot give an LGTM on AUTHORS because I am not sure how
this
> > works. Therefore you have to have someone with authority over that file give
> you
> > an LGTM before you can commit.
> Adding jam as I am not sure who is the correct authority for AUTHORS file. :)

I think anyone can edit it, but I'm not an expert :)

[Ravi Kasibhatla, 2011-10-18 05:23:52]

On 2011/10/17 22:23:23, John Abd-El-Malek wrote:
> On 2011/10/17 17:33:01, nvmw86 wrote:
> > On 2011/10/17 16:58:51, Emmanuel Saint-loubert wrote:
> > > Just to clear I cannot give an LGTM on AUTHORS because I am not sure how
> this
> > > works. Therefore you have to have someone with authority over that file
give
> > you
> > > an LGTM before you can commit.
> > Adding jam as I am not sure who is the correct authority for AUTHORS file.
:)
> 
> I think anyone can edit it, but I'm not an expert :)
Modified AUTHORS as per CLA to ravi.kasibhatla@motorola.com.

[tony, 2011-10-18 16:21:38]

lgtm

[wyck, 2011-10-18 17:22:56]

On 2011/10/18 16:21:38, tony wrote:
> lgtm

lgtm

[Ravi Kasibhatla, 2011-10-19 15:31:36]

On 2011/10/18 17:22:56, wyck wrote:
> On 2011/10/18 16:21:38, tony wrote:
> > lgtm
> 
> lgtm
Hi wyck/tony,
Would you be committing the change or I need to commit it?

[commit-bot: I haz the power, 2011-10-19 17:00:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nvmw86@motorola.com/8316001/6001

[commit-bot: I haz the power, 2011-10-19 17:00:11]

Can't apply patch for file AUTHORS.
While running patch -p1 --forward --force;
patching file AUTHORS
Hunk #1 FAILED at 135.
1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

[tony, 2011-10-19 17:00:15]

On 2011/10/19 15:31:36, nvmw86 wrote:
> On 2011/10/18 17:22:56, wyck wrote:
> > On 2011/10/18 16:21:38, tony wrote:
> > > lgtm
> > 
> > lgtm
> Hi wyck/tony,
> Would you be committing the change or I need to commit it?

I think anyone can check the Commit box.

[tony, 2011-10-19 18:28:23]

Meh, I will land manually.

On 2011/10/19 17:00:11, I haz the power (commit-bot) wrote:
> Can't apply patch for file AUTHORS.
> While running patch -p1 --forward --force;
> patching file AUTHORS
> Hunk #1 FAILED at 135.
> 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

[tony, 2011-10-19 20:42:22]

r106377