Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: webkit/blob/blob_url_request_job.cc

Issue 8315012: base::Bind: Convert FileUtilProxy::GetFileInfoCallback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pipelining. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/blob/blob_url_request_job.cc
diff --git a/webkit/blob/blob_url_request_job.cc b/webkit/blob/blob_url_request_job.cc
index d70536a26443295b136daf1da4d0a2d70acacac5..312c2641f574d8e614cea0354ccf5d3c637e4105 100644
--- a/webkit/blob/blob_url_request_job.cc
+++ b/webkit/blob/blob_url_request_job.cc
@@ -52,7 +52,6 @@ BlobURLRequestJob::BlobURLRequestJob(
BlobData* blob_data,
base::MessageLoopProxy* file_thread_proxy)
: net::URLRequestJob(request),
- ALLOW_THIS_IN_INITIALIZER_LIST(callback_factory_(this)),
ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
blob_data_(blob_data),
file_thread_proxy_(file_thread_proxy),
@@ -111,16 +110,14 @@ void BlobURLRequestJob::Kill() {
CloseStream();
net::URLRequestJob::Kill();
- callback_factory_.RevokeAll();
weak_factory_.InvalidateWeakPtrs();
method_factory_.RevokeAll();
}
void BlobURLRequestJob::ResolveFile(const FilePath& file_path) {
base::FileUtilProxy::GetFileInfo(
- file_thread_proxy_,
- file_path,
- callback_factory_.NewCallback(&BlobURLRequestJob::DidResolve));
+ file_thread_proxy_, file_path,
+ base::Bind(&BlobURLRequestJob::DidResolve, weak_factory_.GetWeakPtr()));
}
void BlobURLRequestJob::DidResolve(base::PlatformFileError rv,

Powered by Google App Engine
This is Rietveld 408576698