Issue 8315012: base::Bind: Convert FileUtilProxy::GetFileInfoCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8315012: base::Bind: Convert FileUtilProxy::GetFileInfoCallback. (Closed)

Created:
9 years, 2 months ago by James Hawkins

Modified:
9 years, 2 months ago

Reviewers:
csilv

CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, kinuko+watch, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base::Bind: Convert FileUtilProxy::GetFileInfoCallback. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105888

Patch Set 1 #

Patch Set 2 : Pipelining. #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -56 lines)			Patch
M	base/file_util_proxy.h	View	1	2 chunks	+5 lines, -5 lines	1 comment	Download
M	base/file_util_proxy.cc	View	1	6 chunks	+10 lines, -12 lines	0 comments	Download
M	webkit/blob/blob_url_request_job.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/blob/blob_url_request_job.cc	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	webkit/fileapi/file_system_file_util_proxy.h	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	webkit/fileapi/file_system_file_util_proxy.cc	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	webkit/fileapi/file_system_operation.cc	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_file_io_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_file_io_impl.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/quota_file_io.h	View		4 chunks	+4 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/quota_file_io.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csilv

9 years, 2 months ago (2011-10-17 20:10:17 UTC) #2

lgtm

http://codereview.chromium.org/8315012/diff/2001/base/file_util_proxy.h
File base/file_util_proxy.h (right):

http://codereview.chromium.org/8315012/diff/2001/base/file_util_proxy.h#newco...
base/file_util_proxy.h:53: typedef Callback2<PlatformFileError /* error code */,
This formatting is a little ugly IMHO, but I'm not sure there's a better option.

Expand Messages | Collapse Messages