Issue 8314005: Initialize the NetworkDelayListener to allow requests rather than deny them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8314005: Initialize the NetworkDelayListener to allow requests rather than deny them. (Closed)

Created:
9 years, 2 months ago by Pam (message me for reviews)

Modified:
9 years, 2 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Initialize the NetworkDelayListener to allow requests rather than deny them. This is necessary for Chrome Frame, which doesn't load extensions. We're relying on the Profile being created (and thus loading extensions) before the session is restored on startup. And as a result, we don't need to watch for NOTIFICATION_EXTENSIONS_READY anymore, nor test that. TBR=aa BUG=99450 TEST=NetworkDelayListener unit tests pass, and chrome_frame_net_tests don't time out Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105687

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -38 lines)			Patch
M	chrome/browser/extensions/network_delay_listener.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/network_delay_listener.cc	View	1	3 chunks	+1 line, -10 lines	0 comments	Download
M	chrome/browser/extensions/network_delay_listener_unittest.cc	View	1	3 chunks	+0 lines, -28 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

Hi Aaron, This small change fixes the chrome_frame_net_tests. Thanks for taking a look. - Pam

9 years, 2 months ago (2011-10-15 22:16:27 UTC) #1

Pam (message me for reviews)

9 years, 2 months ago (2011-10-24 09:17:12 UTC) #2

Ping? I know this was TBR, but I'd appreciate a look to confirm that it's valid.

Thanks,
- Pam

Expand Messages | Collapse Messages