Issue 8314002: Support updating perf_expectations.json on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8314002: Support updating perf_expectations.json on Windows (Closed)

Created:
9 years, 2 months ago by Ryan Sleevi

Modified:
9 years, 2 months ago

Reviewers:
cmp, commit-bot: I haz the power

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Support updating perf_expectations.json on Windows Use #!/usr/bin/env python to locate python, rather than #!/usr/bin/python, for updating on expectations on Cygwin/msysgit R=cmp@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105685

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/perf_expectations/make_expectations.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/perf_expectations/tests/perf_expectations_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Ryan Sleevi

Works fine on msysgit here - and properly locates the depot_tools hermetic python.

9 years, 2 months ago (2011-10-15 20:14:58 UTC) #1

commit-bot: I haz the power

9 years, 2 months ago (2011-10-15 20:17:46 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8314002/1