Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4099)

Unified Diff: base/location.h

Issue 8313013: Support JSON encoding of data for about:tracking information (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/location.cc » ('j') | base/location.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/location.h
===================================================================
--- base/location.h (revision 106875)
+++ base/location.h (working copy)
@@ -8,6 +8,7 @@
#include <string>
#include "base/base_export.h"
+#include "base/values.h"
#ifndef NDEBUG
#ifndef TRACK_ALL_TASK_OBJECTS
@@ -53,12 +54,20 @@
std::string ToString() const;
+ // Translate the some of the state in this instance into a human readable
+ // string with HTML characters in the function names exscaped, and append
ramant (doing other things) 2011/10/24 18:03:49 nit: exscaped -> escaped
jar (doing other things) 2011/10/24 18:43:27 Done.
+ // that string to |output|. Inclusion of the file_name_ and function_name_
+ // are optional, and controlled by the boolean arguments.
void Write(bool display_filename, bool display_function_name,
std::string* output) const;
// Write function_name_ in HTML with '<' and '>' properly encoded.
void WriteFunctionName(std::string* output) const;
+ // Construct a Value* representation. The caller ownns assumes ownership
ramant (doing other things) 2011/10/24 18:03:49 nit: ownns -> owns. Should we say owns and assumes
jar (doing other things) 2011/10/24 18:43:27 Done.
+ // of the memory in the returned instance.
+ base::DictionaryValue* ToValue() const;
+
private:
const char* function_name_;
const char* file_name_;
« no previous file with comments | « no previous file | base/location.cc » ('j') | base/location.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698