Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 8313006: Allow webstore extensions to use experimental permissions. (Closed)

Created:
9 years, 2 months ago by Aaron Boodman
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Allow webstore extensions to use experimental permissions. We will rely on the store to enforce that normal extensions do not contain 'experimental'. Also simplify some code in ExtensionService, Extension, and extension_manifest_unittest.cc. BUG=100487 TBR=jstritar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105734

Patch Set 1 #

Patch Set 2 : commentary #

Patch Set 3 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -222 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 chunks +18 lines, -22 lines 2 comments Download
M chrome/common/extensions/extension.h View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 9 chunks +110 lines, -88 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 1 12 chunks +95 lines, -103 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8313006/1006
9 years, 2 months ago (2011-10-16 14:22:19 UTC) #1
commit-bot: I haz the power
Can't apply patch for file chrome/common/extensions/extension.cc. While running patch -p1 --forward --force; patching file chrome/common/extensions/extension.cc ...
9 years, 2 months ago (2011-10-16 14:22:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8313006/3001
9 years, 2 months ago (2011-10-16 14:53:13 UTC) #3
commit-bot: I haz the power
Change committed as 105734
9 years, 2 months ago (2011-10-16 16:23:20 UTC) #4
Mihai Parparita -not on Chrome
9 years, 2 months ago (2011-10-16 22:41:45 UTC) #5
http://codereview.chromium.org/8313006/diff/3001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/8313006/diff/3001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:1453: int
ExtensionService::GetExtensionCreateFlagsForInstalledExtension(
Seems like this could be a static/in an unnamed namespace function in this file.

http://codereview.chromium.org/8313006/diff/3001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:1456: if
(info->extension_location != Extension::LOAD)
Body is indented one too many times.

Powered by Google App Engine
This is Rietveld 408576698