Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/common/time_format.h

Issue 8313003: Wrap TimeFormat unittests into unnamed namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/time_format_unittest.cc » ('j') | chrome/common/time_format_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/time_format.h
diff --git a/chrome/common/time_format.h b/chrome/common/time_format.h
index d94ac14e30c0d436c5064349b9d39ec63cbab00c..cd2799e8b2db6e62aa2b004d722bcb5f7d44dd59 100644
--- a/chrome/common/time_format.h
+++ b/chrome/common/time_format.h
@@ -2,12 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_COMMON_TIME_FORMAT_H__
-#define CHROME_COMMON_TIME_FORMAT_H__
+#ifndef CHROME_COMMON_TIME_FORMAT_H_
+#define CHROME_COMMON_TIME_FORMAT_H_
#pragma once
-// This file defines methods to format time values as strings.
-
+#include "base/basictypes.h"
#include "base/string16.h"
namespace base {
@@ -15,6 +14,7 @@ class Time;
class TimeDelta;
}
+// This class defines methods to format time values as strings.
Paweł Hajdan Jr. 2011/10/18 09:59:35 nit: Omit "This class defines". Or maybe the whole
tfarina 2011/10/18 16:00:53 Yeah, that is what I had in mind for a follow up p
class TimeFormat {
public:
// TimeElapsed, TimeRemaining and TimeRemainingShort functions:
@@ -46,6 +46,9 @@ class TimeFormat {
// time once at the beginning and pass it for each computation.
static string16 RelativeDate(const base::Time& time,
const base::Time* optional_midnight_today);
+
+ private:
+ DISALLOW_IMPLICIT_CONSTRUCTORS(TimeFormat);
};
-#endif // CHROME_COMMON_TIME_FORMAT_H__
+#endif // CHROME_COMMON_TIME_FORMAT_H_
« no previous file with comments | « no previous file | chrome/common/time_format_unittest.cc » ('j') | chrome/common/time_format_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698