Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5443)

Unified Diff: chrome/browser/sync/engine/download_updates_command.cc

Issue 8313002: Revert 105667 - Send important client side event information to the server. We create a class cal... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/download_updates_command.cc
===================================================================
--- chrome/browser/sync/engine/download_updates_command.cc (revision 105679)
+++ chrome/browser/sync/engine/download_updates_command.cc (working copy)
@@ -16,8 +16,6 @@
using syncable::ScopedDirLookup;
-using sync_pb::DebugInfo;
-
namespace browser_sync {
using sessions::StatusController;
using sessions::SyncSession;
@@ -85,10 +83,6 @@
SyncerProtoUtil::AddRequestBirthday(dir, &client_to_server_message);
- DebugInfo* debug_info = client_to_server_message.mutable_debug_info();
-
- AppendClientDebugInfoIfNeeded(session, debug_info);
-
bool ok = SyncerProtoUtil::PostClientToServerMessage(
client_to_server_message,
&update_response,
@@ -132,21 +126,4 @@
DCHECK_LT(0, requested_type_count) << "Doing GetUpdates with empty filter.";
}
-void DownloadUpdatesCommand::AppendClientDebugInfoIfNeeded(
- sessions::SyncSession* session,
- DebugInfo* debug_info) {
- // We want to send the debug info only once per sync cycle. Check if it has
- // already been sent.
- if (!session->status_controller()->debug_info_sent()) {
- VLOG(1) << "Sending client debug info ...";
- // could be null in some unit tests.
- if (session->context()->debug_info_getter()) {
- session->context()->debug_info_getter()->GetAndClearDebugInfo(
- debug_info);
- }
- session->status_controller()->set_debug_info_sent();
- }
-}
-
-
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/engine/download_updates_command.h ('k') | chrome/browser/sync/engine/download_updates_command_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698