Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 8313002: Revert 105667 - Send important client side event information to the server. We create a class cal... (Closed)

Created:
9 years, 2 months ago by lipalani1
Modified:
9 years, 2 months ago
Reviewers:
lipalani1
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Revert 105667 - Send important client side event information to the server. We create a class called DebugInfoEventListener which implements 2 interfaces. one being the syncmanager::observer to observe events from syncmanager. The other being DebugInfoGetter so that syncer can call this class to give the debug information in protobuf format. The implementation of this class uses a queue. And it limits the number of events to 6. if more than 6 events are in the queue we delete the oldest event. Also we send this information to the server only once per sync cycle during the first getudpdates command. also includes the unit test. BUG=100058 TEST= Review URL: http://codereview.chromium.org/8189003 TBR=lipalani@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -429 lines) Patch
M chrome/browser/sync/engine/download_updates_command.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/sync/engine/download_updates_command.cc View 3 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/sync/engine/download_updates_command_unittest.cc View 3 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/sync_scheduler_whitebox_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/sync/internal_api/debug_info_event_listener.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/sync/internal_api/debug_info_event_listener.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/sync/internal_api/debug_info_event_listener_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.cc View 5 chunks +1 line, -10 lines 0 comments Download
D chrome/browser/sync/protocol/client_debug_info.proto View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/sync/protocol/sync.proto View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/sync/protocol/sync_proto.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sessions/session_state.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/sync/sessions/status_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/sessions/status_controller.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session_context.h View 4 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session_context.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/engine/syncer_command_test.h View 4 chunks +1 line, -17 lines 0 comments Download
D chrome/browser/sync/test/engine/syncer_command_test.cc View 1 chunk +0 lines, -14 lines 0 comments Download
MM chrome/chrome.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
lipalani1
9 years, 2 months ago (2011-10-15 19:13:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698