Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: src/objects-inl.h

Issue 8312015: Changes around ascii-check for strings wrt external strings. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/extensions/externalize-string-extension.cc ('k') | test/mjsunit/string-slices.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 267880d7b88994db40c06c02b69787e09e49577a..06f02625569e2c23e9d7bb00a9992685ad59db78 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -290,8 +290,10 @@ bool String::IsAsciiRepresentationUnderneath() {
return true;
case kTwoByteStringTag:
return false;
- default: // Cons or sliced string. Need to go deeper.
- return GetUnderlying()->IsAsciiRepresentation();
+ default:
+ // Cons or sliced string. Need to go deeper.
+ // Consider slice of cons of externalized.
+ return GetUnderlying()->IsAsciiRepresentationUnderneath();
Erik Corry 2011/10/17 12:05:15 Is it possible to make an arbitraryly deep nesting
}
}
« no previous file with comments | « src/extensions/externalize-string-extension.cc ('k') | test/mjsunit/string-slices.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698