Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 8312015: Changes around ascii-check for strings wrt external strings. (Closed)

Created:
9 years, 2 months ago by Yang
Modified:
9 years, 2 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Changes around ascii-check for strings wrt external strings. Committed: http://code.google.com/p/v8/source/detail?r=9662

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M src/extensions/externalize-string-extension.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/string-slices.js View 1 chunk +30 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Please take a look. Fixes some edge cases for ascii-ness checking.
9 years, 2 months ago (2011-10-17 09:39:15 UTC) #1
Erik Corry
http://codereview.chromium.org/8312015/diff/1/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/8312015/diff/1/src/objects-inl.h#newcode296 src/objects-inl.h:296: return GetUnderlying()->IsAsciiRepresentationUnderneath(); Is it possible to make an arbitraryly ...
9 years, 2 months ago (2011-10-17 12:05:15 UTC) #2
Yang
My bad. A cons string is flattened before a slice can be created from it.
9 years, 2 months ago (2011-10-17 12:09:59 UTC) #3
Erik Corry
9 years, 2 months ago (2011-10-17 12:44:19 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698