Issue 8312004: base/json: Collapse a condition in ReadHexDigits into a single if clause.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8312004: base/json: Collapse a condition in ReadHexDigits into a single if clause. (Closed)

Created:
9 years, 2 months ago by tfarina

Modified:
9 years, 2 months ago

Reviewers:
tony

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base/json: Collapse a condition in ReadHexDigits into a single if clause. TEST=base_unittests --gtest_filter=JSON* R=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106096

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	base/json/json_reader.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LG, although I'm pretty sure it doesn't matter. Why do you prefer the single if ...

9 years, 2 months ago (2011-10-17 16:33:41 UTC) #2

tfarina

9 years, 2 months ago (2011-10-17 18:22:01 UTC) #3

On 2011/10/17 16:33:41, tony wrote:
> LG, although I'm pretty sure it doesn't matter.  Why do you prefer the single
if
> clause?
Easier to read and less lines.

Expand Messages | Collapse Messages