When printing a PDF, query and use the print scaling disabled option.

When printing a PDF, query and use the print scaling disabled option.  Also, some general clean ups.

BUG=67091, 92045, 92218
TEST=Print a PDF with print scaling disabled and see that it takes up the entire page.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105893

[Lei Zhang, 2011-10-17 05:27:02]

lgtm

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1052: bool source_is_html;
I'd initialize this to true in the unlikely event you hit the NOTREACHED so you
get deterministic behavior.

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1062: // When the source is a PDF:
you can move this comment + #if block inside the if statement on line 1078.

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1360: DCHECK(state_ == UNINITIALIZED ||
state_ == INITIALIZED);
Isn't this the same as !IsRendering() ?

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1449: DCHECK(state_ == RENDERING ||
state_ == DONE);
isn't this the same as IsRendering() ?

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1524: WebKit::WebFrame*
PrintWebViewHelper::PrintPreviewContext::frame() const {
Add the same DCHECK as node() ?

[vandebo (ex-Chrome), 2011-10-17 17:03:33]

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1052: bool source_is_html;
On 2011/10/17 05:27:02, Lei Zhang wrote:
> I'd initialize this to true in the unlikely event you hit the NOTREACHED so
you
> get deterministic behavior.

Done.

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1062: // When the source is a PDF:
On 2011/10/17 05:27:02, Lei Zhang wrote:
> you can move this comment + #if block inside the if statement on line 1078.

Done.

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1360: DCHECK(state_ == UNINITIALIZED ||
state_ == INITIALIZED);
On 2011/10/17 05:27:02, Lei Zhang wrote:
> Isn't this the same as !IsRendering() ?

Done.

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1449: DCHECK(state_ == RENDERING ||
state_ == DONE);
On 2011/10/17 05:27:02, Lei Zhang wrote:
> isn't this the same as IsRendering() ?

Done.

http://codereview.chromium.org/8312003/diff/6001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1524: WebKit::WebFrame*
PrintWebViewHelper::PrintPreviewContext::frame() const {
On 2011/10/17 05:27:02, Lei Zhang wrote:
> Add the same DCHECK as node() ?

Currently, this triggers a DCHECK in one of the tests.  I'm going to talk to
Arthur about it and probably add it in a follow up CL.

[commit-bot: I haz the power, 2011-10-17 17:03:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/8312003/7001

[commit-bot: I haz the power, 2011-10-17 17:05:18]

Try job failure for 8312003-7001 on win_rel for steps "update_scripts, update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[kmadhusu, 2011-10-17 17:09:33]

http://codereview.chromium.org/8312003/diff/7001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/8312003/diff/7001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1054: if
(!job_settings->GetBoolean(printing::kSettingPreviewModifiable,
nit: Fix indentation

[vandebo (ex-Chrome), 2011-10-17 17:34:35]

http://codereview.chromium.org/8312003/diff/7001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/8312003/diff/7001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper.cc:1054: if
(!job_settings->GetBoolean(printing::kSettingPreviewModifiable,
On 2011/10/17 17:09:33, kmadhusu wrote:
> nit: Fix indentation

Done.

[commit-bot: I haz the power, 2011-10-17 17:34:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/8312003/9002

[kmadhusu, 2011-10-17 17:51:48]

Thanks for fixing the nit.

On 2011/10/17 17:34:35, vandebo wrote:
>
http://codereview.chromium.org/8312003/diff/7001/chrome/renderer/print_web_vi...
> File chrome/renderer/print_web_view_helper.cc (right):
> 
>
http://codereview.chromium.org/8312003/diff/7001/chrome/renderer/print_web_vi...
> chrome/renderer/print_web_view_helper.cc:1054: if
> (!job_settings->GetBoolean(printing::kSettingPreviewModifiable,
> On 2011/10/17 17:09:33, kmadhusu wrote:
> > nit: Fix indentation
> 
> Done.

[commit-bot: I haz the power, 2011-10-17 20:20:42]

Change committed as 105893