Issue 8312001: Revert 105668 - When StartFailed for a datatype the fix is to call StopAssociation which would ca...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8312001: Revert 105668 - When StartFailed for a datatype the fix is to call StopAssociation which would ca... (Closed)

Created:
9 years, 2 months ago by lipalani1

Modified:
9 years, 2 months ago

Reviewers:
lipalani1

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 105668 - When StartFailed for a datatype the fix is to call StopAssociation which would call DisassociateModel and clear off the change processor and model associator. When stop is called later on the same datatype we dont call StopAssociationAsync any more (which would be implemented in the datatypes' sub class) if the datatype never started succesfully. (The assertion was in this code because we were calling StopAssociationAsync on a datatype that failed to start). BUG=100057 TEST= Review URL: http://codereview.chromium.org/8305006 TBR=lipalani@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105674

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -32 lines)			Patch
	M	chrome/browser/sync/glue/non_frontend_data_type_controller.cc	View		2 chunks	+24 lines, -31 lines	0 comments	Download
	M	chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages