GTK: add TEXT_URI_LIST as a data type for drags from the omnibox.

chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/autocomplete/autocomplete_edit.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "chrome/browser/autocomplete/autocomplete_popup_model.h"
 #include "chrome/browser/bookmarks/bookmark_node_data.h"
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/instant/instant_controller.h"
 #include "chrome/browser/platform_util.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/gtk/gtk_util.h"
 #include "chrome/browser/ui/gtk/view_id_util.h"
 #include "chrome/browser/ui/toolbar/toolbar_model.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/common/notification_service.h"
 #include "googleurl/src/gurl.h"
 #include "grit/generated_resources.h"
 #include "net/base/escape.h"
 #include "third_party/undoview/undo_view.h"
 #include "ui/base/animation/multi_animation.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
+#include "ui/base/dragdrop/gtk_dnd_util.h"
 #include "ui/base/gtk/gtk_hig_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/font.h"
 #include "ui/gfx/gtk_util.h"
 #include "ui/gfx/skia_utils_gtk.h"
 
 #if defined(TOOLKIT_VIEWS)
 #include "chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h"
@@ skipping 191 matching lines @@
   alignment_.Own(gtk_alignment_new(0., 0.5, 1.0, 0.0));
   gtk_widget_set_name(alignment_.get(),
                       "chrome-autocomplete-edit-view");
 
   // The GtkTagTable and GtkTextBuffer are not initially unowned, so we have
   // our own reference when we create them, and we own them.  Adding them to
   // the other objects adds a reference; it doesn't adopt them.
   tag_table_ = gtk_text_tag_table_new();
   text_buffer_ = gtk_text_buffer_new(tag_table_);
   g_object_set_data(G_OBJECT(text_buffer_), kOmniboxViewGtkKey, this);
+  copy_targets_ = gtk_text_buffer_get_copy_target_list(text_buffer_);

[Evan Stade, 2011/10/21 19:16:11]

doing this opens a can of worms regarding object ownership/lifetime, I'd rather
you just call get_copy_target_list each time you need it.

[SanjoyPal, 2011/10/22 03:34:02]

Done.

 
   // We need to run this two handlers before undo manager's handlers, so that
   // text iterators modified by these handlers can be passed down to undo
   // manager's handlers.
   g_signal_connect(text_buffer_, "delete-range",
                    G_CALLBACK(&HandleDeleteRangeThunk), this);
   g_signal_connect(text_buffer_, "mark-set",
                    G_CALLBACK(&HandleMarkSetAlwaysThunk), this);
 
   text_view_ = gtk_undo_view_new(text_buffer_);
@@ skipping 1340 matching lines @@
   }
 }
 
 void OmniboxViewGtk::HandleDragDataGet(GtkWidget* widget,
                                        GdkDragContext* context,
                                        GtkSelectionData* selection_data,
                                        guint target_type,
                                        guint time) {
   DCHECK(text_view_);
   // If GTK put the normal textual version of the selection in our drag data,
   // put our doctored selection that might have the 'http://' prefix. Also, GTK

[Evan Stade, 2011/10/21 19:16:11]

you can remove the comment about the switch

[SanjoyPal, 2011/10/22 03:34:02]

Done.

   // is confused about signedness of its datatypes, leading to the weird switch
   // statement (no set of casts fixes this).
   switch (target_type) {
     case GTK_TEXT_BUFFER_TARGET_INFO_TEXT: {
       gtk_selection_data_set_text(selection_data, dragged_text_.c_str(), -1);
+      break;
+    }
+    case ui::TEXT_URI_LIST: {
+      TabContents* current_tab =
+          BrowserList::GetLastActive()->GetSelectedTabContents();
+      string16 tab_title = current_tab->GetTitle();
+      // Pass an empty string if user has edited the URL.
+      if (current_tab->GetURL().spec() != dragged_text_)
+        tab_title = string16();
+      ui::WriteURLWithName(selection_data, GURL(dragged_text_),
+                           tab_title, target_type);
+      break;
     }
   }
 }
 
 void OmniboxViewGtk::HandleDragBegin(GtkWidget* widget,
                                        GdkDragContext* context) {
+  // Add TEXT_URI_TARGET to the omnibox target list only if its a valid url.
+  if (GURL(selected_text_).is_valid())

[Evan Stade, 2011/10/21 19:16:11]

no. You need to use AdjustTextForCopy

[SanjoyPal, 2011/10/22 03:34:02]

Done.

+    gtk_target_list_add_uri_targets(copy_targets_, ui::TEXT_URI_LIST);
   dragged_text_ = selected_text_;
 }
 
 void OmniboxViewGtk::HandleDragEnd(GtkWidget* widget,
                                        GdkDragContext* context) {
+  GdkAtom text_uri_atom = ui::GetAtomForTarget(ui::TEXT_URI_LIST);
+  if (gtk_target_list_find(copy_targets_, text_uri_atom, NULL))

[Evan Stade, 2011/10/21 19:16:11]

I don't think you need this check

[SanjoyPal, 2011/10/22 03:34:02]

Done.

+    gtk_target_list_remove(copy_targets_, text_uri_atom);
   dragged_text_.clear();
 }
 
 void OmniboxViewGtk::HandleInsertText(GtkTextBuffer* buffer,
                                       GtkTextIter* location,
                                       const gchar* text,
                                       gint len) {
   std::string filtered_text;
   filtered_text.reserve(len);
 
@@ skipping 718 matching lines @@
   // baseline, so we need to move the |instant_view_| down to make sure it
   // has the same baseline as the |text_view_|.
   PangoLayout* layout = gtk_label_get_layout(GTK_LABEL(instant_view_));
   int height;
   pango_layout_get_size(layout, NULL, &height);
   PangoLayoutIter* iter = pango_layout_get_iter(layout);
   int baseline = pango_layout_iter_get_baseline(iter);
   pango_layout_iter_free(iter);
   g_object_set(instant_anchor_tag_, "rise", baseline - height, NULL);
 }