GTK: add TEXT_URI_LIST as a data type for drags from the omnibox.

chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
 
 #include <algorithm>
@@ skipping 15 matching lines @@
 #include "chrome/browser/ui/toolbar/toolbar_model.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/common/notification_service.h"
 #include "googleurl/src/gurl.h"
 #include "grit/generated_resources.h"
 #include "net/base/escape.h"
 #include "third_party/undoview/undo_view.h"
 #include "ui/base/animation/multi_animation.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
+#include "ui/base/dragdrop/gtk_dnd_util.h"
 #include "ui/base/gtk/gtk_hig_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/font.h"
 #include "ui/gfx/gtk_util.h"
 #include "ui/gfx/skia_utils_gtk.h"
 
 #if defined(TOOLKIT_VIEWS)
 #include "chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h"
@@ skipping 191 matching lines @@
   alignment_.Own(gtk_alignment_new(0., 0.5, 1.0, 0.0));
   gtk_widget_set_name(alignment_.get(),
                       "chrome-autocomplete-edit-view");
 
   // The GtkTagTable and GtkTextBuffer are not initially unowned, so we have
   // our own reference when we create them, and we own them.  Adding them to
   // the other objects adds a reference; it doesn't adopt them.
   tag_table_ = gtk_text_tag_table_new();
   text_buffer_ = gtk_text_buffer_new(tag_table_);
   g_object_set_data(G_OBJECT(text_buffer_), kOmniboxViewGtkKey, this);
+  GtkTargetList* targets = gtk_text_buffer_get_copy_target_list(text_buffer_);
+  gtk_target_list_add_uri_targets(targets, ui::TEXT_URI_LIST);

[Evan Stade, 2011/10/17 21:55:59]

this isn't right, if I select just a small part of the text and start dragging
then it's not a URI. Basically if we are not adding the scheme onto the front
then it shouldn't have this target.

[SanjoyPal, 2011/10/18 08:15:30]

Yes, then it will be treated as TEXT_PLAIN.

"Basically if we are not adding the scheme onto the front
then it shouldn't have this target."

I guess, i dint understand this statement completely. Can you please explain
more?

[Evan Stade, 2011/10/18 16:27:31]

we don't display the scheme in the http:// case. However in certain cases on
copy we do put the http:// on the front of the clipboard data. In these same
cases we should make URI list available, but in the cases where we don't put
http:// on the front of the clipboard data (e.g., "foo" is selected in
bar.com/foo) we should not advertise TEXT_URI_LIST

 
   // We need to run this two handlers before undo manager's handlers, so that
   // text iterators modified by these handlers can be passed down to undo
   // manager's handlers.
   g_signal_connect(text_buffer_, "delete-range",
                    G_CALLBACK(&HandleDeleteRangeThunk), this);
   g_signal_connect(text_buffer_, "mark-set",
                    G_CALLBACK(&HandleMarkSetAlwaysThunk), this);
 
   text_view_ = gtk_undo_view_new(text_buffer_);
@@ skipping 1346 matching lines @@
                                        guint target_type,
                                        guint time) {
   DCHECK(text_view_);
   // If GTK put the normal textual version of the selection in our drag data,
   // put our doctored selection that might have the 'http://' prefix. Also, GTK
   // is confused about signedness of its datatypes, leading to the weird switch
   // statement (no set of casts fixes this).
   switch (target_type) {
     case GTK_TEXT_BUFFER_TARGET_INFO_TEXT: {
       gtk_selection_data_set_text(selection_data, dragged_text_.c_str(), -1);
+      break;
+    }
+    case ui::TEXT_URI_LIST: {
+      ui::WriteURLWithName(selection_data, GURL(dragged_text_),
+                           UTF8ToUTF16(dragged_text_), target_type);

[Evan Stade, 2011/10/17 21:55:59]

the name should be the tab title

[SanjoyPal, 2011/10/18 08:15:30]

The title is not being used in TEXT_URI_LIST case inside ui::WriteURLWithName.
And user can edit the url in omnibox before dragging, url and title may not
match. So can we pass it as empty string?

[Evan Stade, 2011/10/18 16:27:31]

well, don't use TEXT_URI_LIST then
I see the tab title/URL mismatch as a corner case. But I guess if you want you
can pass an empty string when less than the full text is selected or the user
has edited the text.

+      break;
     }
   }
 }
 
 void OmniboxViewGtk::HandleDragBegin(GtkWidget* widget,
                                        GdkDragContext* context) {
   dragged_text_ = selected_text_;
 }
 
 void OmniboxViewGtk::HandleDragEnd(GtkWidget* widget,
@@ skipping 729 matching lines @@
   // baseline, so we need to move the |instant_view_| down to make sure it
   // has the same baseline as the |text_view_|.
   PangoLayout* layout = gtk_label_get_layout(GTK_LABEL(instant_view_));
   int height;
   pango_layout_get_size(layout, NULL, &height);
   PangoLayoutIter* iter = pango_layout_get_iter(layout);
   int baseline = pango_layout_iter_get_baseline(iter);
   pango_layout_iter_free(iter);
   g_object_set(instant_anchor_tag_, "rise", baseline - height, NULL);
 }