Revert 105669 - Additional infrastructure code supporting the report fraudulent certificate chain...

Revert 105669 - Additional infrastructure code supporting the report fraudulent certificate chains feature.

BUG=99185
Review URL: http://codereview.chromium.org/8055027

TBR=palmer@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105675

[Ryan Sleevi, 2011-10-15 18:10:06]

Investigating on IRC, it seemed that this CL caused chrome-si to jump from 291
to 292 - which turns the sizes bot red.

It's not clear why this CL did that, as I don't see  anything in this CL that
would do it, but you can see the differences pretty easily:

Prior to revert:
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/15591/steps/...
*RESULT chrome-si: initializers= 292 files

Following revert:
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/15592/steps/...
*RESULT chrome-si: initializers= 291 files

[Chris Palmer, 2011-10-15 18:20:12]

On 2011/10/15 18:10:06, Ryan Sleevi wrote:
> Investigating on IRC, it seemed that this CL caused chrome-si to jump from 291
> to 292 - which turns the sizes bot red.
> 
> It's not clear why this CL did that, as I don't see  anything in this CL that
> would do it, but you can see the differences pretty easily:
> 
> Prior to revert:
>
http://build.chromium.org/p/chromium/builders/Linux%2520x64/builds/15591/step...
> *RESULT chrome-si: initializers= 292 files
> 
> Following revert:
>
http://build.chromium.org/p/chromium/builders/Linux%2520x64/builds/15592/step...
> *RESULT chrome-si: initializers= 291 files

Those links are 404 for me. I don't see any static initializers in the code at
all. How could I possibly fix this? This code is necessary for this feature to
work.

[Ryan Sleevi, 2011-10-15 18:26:34]

On 2011/10/15 18:20:12, Chris Palmer wrote:
> Those links are 404 for me. I don't see any static initializers in the code at
> all. How could I possibly fix this? This code is necessary for this feature to
> work.

Click the links in the e-mail. Alternatively, codereview seems to be
double-escaping the percent-2-0 as percent-2-5-2-0, so you should just be able
to delete the 2-5 from the URL. Hopefully that makes sense.

It's not clear to me at all why chrome-si was triggered on this. I've looked
over this CL several times, and the other CL that was in the window when this
triggered (http://crrev.com/105668), and neither triggered.

The sizes script is located in tools/build/scripts/slave/chromium/sizes (note:
this is not under src/, you'll need to explicitly check out it from
http://src.chromium.org/svn/trunk/tools/.../ ). You can run it under Linux and
see.

TBH, this is probably the oddest bloat I've seen - but the sizes step failed
consistently, so I don't believe it's flaky

Note, originally you were reverted because of http://crbug.com/88844, which IS
transient flake, but it just happened that 88844 triggered the same time and for
the same CLs as sizes, and when they were both reverted for 88844, sizes went
green.