Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 8310016: DartC parser stress test (Closed)

Created:
9 years, 2 months ago by danrubel
Modified:
9 years, 2 months ago
Reviewers:
jbrosenberg, jat
CC:
reviews_dartlang.org
Visibility:
Public.

Description

DartC parser stress test Identical to and commited as http://codereview.chromium.org/8322010/

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -17 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 10 chunks +13 lines, -9 lines 2 comments Download
M compiler/java/com/google/dart/compiler/parser/DartScanner.java View 10 chunks +28 lines, -8 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/ParserTests.java View 1 chunk +1 line, -0 lines 0 comments Download
A compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java View 1 1 chunk +153 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
I was stress testing the code completion engine and bumped into some parser issues. That ...
9 years, 2 months ago (2011-10-17 10:35:58 UTC) #1
jat
LGTM http://codereview.chromium.org/8310016/diff/1005/compiler/java/com/google/dart/compiler/parser/DartParser.java File compiler/java/com/google/dart/compiler/parser/DartParser.java (right): http://codereview.chromium.org/8310016/diff/1005/compiler/java/com/google/dart/compiler/parser/DartParser.java#newcode2765 compiler/java/com/google/dart/compiler/parser/DartParser.java:2765: reportErrorWithoutAdvancing(DartCompilerErrorCode.UNEXPECTED_TOKEN); Shouldn't this be a message saying a ...
9 years, 2 months ago (2011-10-17 14:05:47 UTC) #2
danrubel
9 years, 2 months ago (2011-10-17 15:12:29 UTC) #3
http://codereview.chromium.org/8310016/diff/1005/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8310016/diff/1005/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2765:
reportErrorWithoutAdvancing(DartCompilerErrorCode.UNEXPECTED_TOKEN);
On 2011/10/17 14:05:48, jat wrote:
> Shouldn't this be a message saying a close paren was expected?

Good point.
Looks like that needs to be addressed in a number of places,
so I'll leave that for a subsequent CL.

Powered by Google App Engine
This is Rietveld 408576698