chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc - Issue 8310014: Only send the client-side phishing model to a renderer if its profile has SafeBrowsing enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

Issue 8310014: Only send the client-side phishing model to a renderer if its profile has SafeBrowsing enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add a comment as Noe suggested Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

index 7e34cd6aaf7128020f649d27ea4557cae9ec40f0..af255305ac3bd3633e2997cff15d3da00ed7d6e5 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

@@ -193,4 +193,17 @@ TEST_F(PhishingClassifierTest, TestClassification) {

EXPECT_EQ(PhishingClassifier::kInvalidScore, phishy_score);

}

+TEST_F(PhishingClassifierTest, DisableDetection) {

+ // No scorer yet, so the classifier is not ready.

+ EXPECT_FALSE(classifier_->is_ready());

+ // Now set the scorer.

+ classifier_->set_phishing_scorer(scorer_.get());

+ EXPECT_TRUE(classifier_->is_ready());

+ // Set a NULL scorer, which turns detection back off.

+ classifier_->set_phishing_scorer(NULL);

+ EXPECT_FALSE(classifier_->is_ready());

} // namespace safe_browsing