Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 8310003: Disable tests that consistently fail on the trybots, making the cq useless. (Closed)

Created:
9 years, 2 months ago by Nico
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable tests that consistently fail on the trybots, making the cq useless. Comment 2 on the bug has a theory why this might be. Please get these tests enabled again quickly. BUG=100467 TEST=commit queue goes berserk less often. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105684

Patch Set 1 #

Total comments: 1

Patch Set 2 : bug comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
9 years, 2 months ago (2011-10-15 19:17:16 UTC) #1
Ryan Sleevi
LGTM http://codereview.chromium.org/8310003/diff/1/chrome/browser/ui/browser_browsertest.cc File chrome/browser/ui/browser_browsertest.cc (right): http://codereview.chromium.org/8310003/diff/1/chrome/browser/ui/browser_browsertest.cc#newcode879 chrome/browser/ui/browser_browsertest.cc:879: IN_PROC_BROWSER_TEST_F( Add a reference to the bug here ...
9 years, 2 months ago (2011-10-15 19:18:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8310003/3001
9 years, 2 months ago (2011-10-15 19:20:40 UTC) #3
commit-bot: I haz the power
Change committed as 105684
9 years, 2 months ago (2011-10-15 20:51:00 UTC) #4
koz (OOO until 15th September)
9 years, 2 months ago (2011-10-17 00:42:14 UTC) #5
On 2011/10/15 20:51:00, I haz the power (commit-bot) wrote:
> Change committed as 105684

LGTM.

Powered by Google App Engine
This is Rietveld 408576698