chrome/common/extensions/docs/examples/extensions/imageinfo/manifest.json - Issue 8310002: Adding `content_security_policy` to imageinfo extension.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/examples/extensions/imageinfo/manifest.json

Issue 8310002: Adding `content_security_policy` to imageinfo extension. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/docs/examples/extensions/imageinfo/info.html ('K') | « chrome/common/extensions/docs/examples/extensions/imageinfo/info.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name" : "Imageinfo",	2 "name" : "Imageinfo",

3 "version" : "1.0.0",	3 "version" : "1.0.1",

4 "description" : "Get image info for images, including EXIF data",	4 "description" : "Get image info for images, including EXIF data",

5 "background_page" : "background.html",	5 "background_page" : "background.html",

6 "permissions" : [	6 "permissions" : [

7 "contextMenus",	7 "contextMenus",

8 "tabs",	8 "tabs",

9 "http:///",	9 "http:///",

10 "https:///"	10 "https:///"

11 ],	11 ],

12 "minimum_chrome_version" : "6.0.0.0",	12 "minimum_chrome_version" : "6.0.0.0",

13 "icons" : {	13 "icons" : {

14 "16" : "imageinfo-16.png",	14 "16" : "imageinfo-16.png",

15 "48" : "imageinfo-48.png",	15 "48" : "imageinfo-48.png",

16 "128" : "imageinfo-128.png"	16 "128" : "imageinfo-128.png"

17 }	17 },

	18 "content_security_policy": "default-src 'self'; connect-src talkingpointsmemo. com"
	abarth-chromium 2011/10/15 18:23:12 When you just specify a host name like you've done When you just specify a host name like you've done in connect-src, that inherits the current scheme, which is chrome-extension. You probably want to put the http and https schemes explicitly. abarth-chromium 2011/10/15 18:24:44 Maybe this is the wrong CSP policy? I don't reall Maybe this is the wrong CSP policy? I don't really see any references to talkingpointsmemo in the extension and I'd expect something like img-src . Use mkwst_at_chromium.org plz.* 2011/10/15 18:41:26 I uploaded the wrong patch. :) I was experimentin Show quoted text On 2011/10/15 18:24:44, abarth wrote: > Maybe this is the wrong CSP policy? I don't really see any references to > talkingpointsmemo in the extension and I'd expect something like img-src *. I uploaded the wrong patch. :) I was experimenting on that website to test things.
	19

18 }	20 }

OLD	NEW