Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: remoting/client/chromoting_stats.cc

Issue 8310001: Show framerate in chromoting debug log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: oops.. compile error. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/chromoting_stats.cc
diff --git a/remoting/client/chromoting_stats.cc b/remoting/client/chromoting_stats.cc
index 9acaedc7664512730aa6d9854f062ac6a834bda8..a7aff74e988486491983a0b3b718f82bf5ac68c0 100644
--- a/remoting/client/chromoting_stats.cc
+++ b/remoting/client/chromoting_stats.cc
@@ -7,8 +7,14 @@
namespace {
// The default window of bandwidth in seconds. Bandwidth is reported as
-// number of numbers received in this time frame.
-static const int kBandwidthWindow = 3;
+// number of bytes received in this time frame.
+static const base::TimeDelta kBandwidthWindow =
+ base::TimeDelta::FromSeconds(3);
Wez 2011/10/21 18:01:43 I think these still need to be const int, and be c
+
+// Framerate is reported as number of frames received over the following
+// time window in seconds.
+static const base::TimeDelta kFramerateWindow =
+ base::TimeDelta::FromSeconds(3);
Wez 2011/10/21 18:01:43 Why do we need separate frame-rate and bandwidth w
// We take the last 10 latency numbers and report the average.
static const int kLatencyWindow = 10;
@@ -18,7 +24,8 @@ static const int kLatencyWindow = 10;
namespace remoting {
ChromotingStats::ChromotingStats()
- : video_bandwidth_(base::TimeDelta::FromSeconds(kBandwidthWindow)),
+ : video_bandwidth_(kBandwidthWindow),
+ video_frame_rate_(kFramerateWindow),
video_capture_ms_(kLatencyWindow),
video_encode_ms_(kLatencyWindow),
video_decode_ms_(kLatencyWindow),

Powered by Google App Engine
This is Rietveld 408576698