Adding `content_security_policy` to a few sample extensions.

Adding `content_security_policy` to 10 sample extensions.

Touched:
* contentSettings
* contextMenus/basic
* browserAction/set_icon_path
* app_launcher
* devtools/network/chrome-firephp
* extension/isAllowedAccess
* news_a11y
* notifications
* omnibox/extension-docs
* pageAction/pageaction_by_url

As a drive-by, fixed the broken `contentscript_xhr` by changing to Twitter's
new API endpoint

BUG=92644
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107084

[Mike West, 2011-10-15 07:59:46]

Boris, can you review these 4 extension changes?

Adam, can you confirm that `content_security_policy` doesn't have any effect on
content scripts? I'm thinking of
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/common/extensi...
in particular.

Thanks to you both!

-Mike

[Mike West, 2011-10-15 08:02:14]

(I'll rebuild the zips and sample.html before committing... I just didn't want
to wait for it to run before uploading this patch. ;) )

[abarth-chromium, 2011-10-15 08:55:25]

http://codereview.chromium.org/8309001/diff/1/chrome/common/extensions/docs/e...
File
chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json
(right):

http://codereview.chromium.org/8309001/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json:11:
"content_security_policy": "default-src 'self';"
No need for a ; at the end.

[Boris Smus, 2011-10-18 21:51:37]

Few comments.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/contentSettings/popup.html
(right):

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/contentSettings/popup.html:5: <script
src="./popup.js"></script>
Equivalent to "popup.js". Only mention it because in other samples (other CL)
you use the other naming convention. Don't think this is a big deal.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
File
chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/manifest.json
(right):

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/manifest.json:2:
"name" : "`extension.isAllowed???Access` Example",
Might as well fix this up too.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/notifications/error.html
(right):

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/notifications/error.html:4: Copyright
2010 the Chromium Authors
Rev date.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/notifications/error.html:25: and
Google Chrome 5 and up on the Mac and Linux.
Seems irrelevant.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/extensions/news_a11y/feed.html
(right):

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/extensions/news_a11y/feed.html:5: <script
id="iframe_script" type="text/not-javascript-i-swear">
How come we're doing this? Also, we should use an x- for non-standard mime
types.

[Mike West, 2011-10-19 09:43:57]

Thanks!

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/contentSettings/popup.html
(right):

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/contentSettings/popup.html:5: <script
src="./popup.js"></script>
On 2011/10/18 21:51:38, Boris Smus wrote:
> Equivalent to "popup.js". Only mention it because in other samples (other CL)
> you use the other naming convention. Don't think this is a big deal.

Done.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
File
chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/manifest.json
(right):

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/manifest.json:2:
"name" : "`extension.isAllowed???Access` Example",
On 2011/10/18 21:51:38, Boris Smus wrote:
> Might as well fix this up too. 

Done.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/notifications/error.html
(right):

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/notifications/error.html:4: Copyright
2010 the Chromium Authors
On 2011/10/18 21:51:38, Boris Smus wrote:
> Rev date.

Done.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/notifications/error.html:25: and
Google Chrome 5 and up on the Mac and Linux.
On 2011/10/18 21:51:38, Boris Smus wrote:
> Seems irrelevant.

Done.

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/extensions/news_a11y/feed.html
(right):

http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/extensions/news_a11y/feed.html:5: <script
id="iframe_script" type="text/not-javascript-i-swear">
On 2011/10/18 21:51:38, Boris Smus wrote:
> How come we're doing this? Also, we should use an x- for non-standard mime
> types.

We're doing this because I was too lazy to rewrite the extension's iframe
weirdness. Now I've rewritten it. :)

[Boris Smus, 2011-10-24 17:24:01]

sorry for the delay. lgtm

[Mike West, 2011-10-25 09:25:30]

On 2011/10/24 17:24:01, Boris Smus wrote:
> sorry for the delay. lgtm

Landing this now, thanks Boris! :)