Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 8309001: Adding `content_security_policy` to a few sample extensions. (Closed)

Created:
9 years, 2 months ago by Mike West
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Adding `content_security_policy` to 10 sample extensions. Touched: * contentSettings * contextMenus/basic * browserAction/set_icon_path * app_launcher * devtools/network/chrome-firephp * extension/isAllowedAccess * news_a11y * notifications * omnibox/extension-docs * pageAction/pageaction_by_url As a drive-by, fixed the broken `contentscript_xhr` by changing to Twitter's new API endpoint BUG=92644 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107084

Patch Set 1 #

Total comments: 1

Patch Set 2 : Dropping extra `;`. #

Patch Set 3 : Moar. #

Patch Set 4 : Adding "news_a11y" sample. #

Patch Set 5 : Notifications sample. #

Patch Set 6 : omnibox/extension-docs #

Patch Set 7 : pageAction/pageaction_by_url #

Total comments: 10

Patch Set 8 : Boris' feedback. #

Patch Set 9 : Docs. Zips. #

Patch Set 10 : License and whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1255 lines, -1539 lines) Patch
M chrome/common/extensions/docs/examples/api/browserAction/set_icon_path.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/background.html View 1 chunk +7 lines, -18 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/background.js View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/contentSettings.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/contentSettings/manifest.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/contentSettings/popup.html View 1 2 3 4 5 6 7 1 chunk +48 lines, -81 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/contentSettings/popup.js View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/contextMenus/basic.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/contextMenus/basic/manifest.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/background.html View 1 2 1 chunk +7 lines, -16 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/background.js View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/devtools.html View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/devtools.js View 1 2 3 4 5 6 7 8 9 1 chunk +185 lines, -181 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/extension/isAllowedAccess.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/manifest.json View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/popup.html View 1 2 2 chunks +2 lines, -9 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/popup.js View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/notifications.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/notifications/background.html View 1 2 3 4 1 chunk +9 lines, -48 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/notifications/background.js View 1 2 3 4 5 6 7 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/notifications/error.html View 1 2 3 4 5 6 7 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/notifications/manifest.json View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/notifications/options.html View 1 2 3 4 1 chunk +32 lines, -75 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/notifications/options.js View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/notifications/style.css View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/omnibox/extension-docs.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/omnibox/extension-docs/background.html View 1 2 3 4 5 1 chunk +1 line, -412 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/omnibox/extension-docs/background.js View 1 2 3 4 5 6 7 8 9 1 chunk +414 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/omnibox/extension-docs/manifest.json View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url/background.html View 1 2 3 4 5 6 1 chunk +1 line, -13 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url/background.js View 1 2 3 4 5 6 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url/manifest.json View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/app_launcher.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/app_launcher/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/app_launcher/popup.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/app_launcher/popup.html View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/app_launcher/popup.js View 1 2 3 4 5 6 7 8 9 7 chunks +47 lines, -32 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/news_a11y.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/news_a11y/feed.css View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/news_a11y/feed.html View 1 2 3 4 5 6 7 1 chunk +8 lines, -377 lines 0 comments Download
A + chrome/common/extensions/docs/examples/extensions/news_a11y/feed.js View 1 2 3 4 5 6 7 11 chunks +76 lines, -180 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/news_a11y/feed_iframe.css View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/news_a11y/feed_iframe.js View 1 2 3 4 5 6 7 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/news_a11y/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/howto/contentscript_xhr.zip View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/howto/contentscript_xhr/contentscript.js View 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 2 3 4 5 6 7 8 13 chunks +31 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 4 5 6 7 8 13 chunks +33 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike West
Boris, can you review these 4 extension changes? Adam, can you confirm that `content_security_policy` doesn't ...
9 years, 2 months ago (2011-10-15 07:59:46 UTC) #1
Mike West
(I'll rebuild the zips and sample.html before committing... I just didn't want to wait for ...
9 years, 2 months ago (2011-10-15 08:02:14 UTC) #2
abarth-chromium
http://codereview.chromium.org/8309001/diff/1/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json File chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json (right): http://codereview.chromium.org/8309001/diff/1/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json#newcode11 chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json:11: "content_security_policy": "default-src 'self';" No need for a ; at ...
9 years, 2 months ago (2011-10-15 08:55:25 UTC) #3
Boris Smus
Few comments. http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/docs/examples/api/contentSettings/popup.html File chrome/common/extensions/docs/examples/api/contentSettings/popup.html (right): http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/docs/examples/api/contentSettings/popup.html#newcode5 chrome/common/extensions/docs/examples/api/contentSettings/popup.html:5: <script src="./popup.js"></script> Equivalent to "popup.js". Only mention ...
9 years, 2 months ago (2011-10-18 21:51:37 UTC) #4
Mike West
Thanks! http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/docs/examples/api/contentSettings/popup.html File chrome/common/extensions/docs/examples/api/contentSettings/popup.html (right): http://codereview.chromium.org/8309001/diff/9002/chrome/common/extensions/docs/examples/api/contentSettings/popup.html#newcode5 chrome/common/extensions/docs/examples/api/contentSettings/popup.html:5: <script src="./popup.js"></script> On 2011/10/18 21:51:38, Boris Smus wrote: ...
9 years, 2 months ago (2011-10-19 09:43:57 UTC) #5
Boris Smus
sorry for the delay. lgtm
9 years, 2 months ago (2011-10-24 17:24:01 UTC) #6
Mike West
9 years, 2 months ago (2011-10-25 09:25:30 UTC) #7
On 2011/10/24 17:24:01, Boris Smus wrote:
> sorry for the delay. lgtm

Landing this now, thanks Boris! :)

Powered by Google App Engine
This is Rietveld 408576698