Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7434)

Unified Diff: chrome/browser/sync/sync_global_error_unittest.cc

Issue 8308005: Suppress bubble view for CONNECTION_FAILED error (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed failure in debug build Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_global_error.cc ('k') | chrome/browser/sync/sync_ui_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_global_error_unittest.cc
diff --git a/chrome/browser/sync/sync_global_error_unittest.cc b/chrome/browser/sync/sync_global_error_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ca0e38554a96926c0ffc70f5c8a20cf97158b48d
--- /dev/null
+++ b/chrome/browser/sync/sync_global_error_unittest.cc
@@ -0,0 +1,122 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/sync/sync_global_error.h"
+
+#include "base/basictypes.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/sync/profile_sync_service_mock.h"
+#include "content/browser/browser_thread.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gmock/include/gmock/gmock-actions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using ::testing::Return;
+using ::testing::NiceMock;
+
+namespace {
+
+// Utility function to test that SyncGlobalError behaves correct for the given
+// error condition.
+void VerifySyncGlobalErrorResult(NiceMock<ProfileSyncServiceMock>* service,
+ SyncGlobalError* error,
+ GoogleServiceAuthError::State error_state,
+ bool is_signed_in,
+ bool is_error) {
+ GoogleServiceAuthError auth_error(error_state);
+ service->UpdateAuthErrorState(auth_error);
+
+ EXPECT_CALL(*service, HasSyncSetupCompleted())
+ .WillRepeatedly(Return(is_signed_in));
+ if (error_state == GoogleServiceAuthError::SERVICE_UNAVAILABLE) {
+ EXPECT_CALL(*service, GetAuthenticatedUsername())
+ .WillRepeatedly(Return(UTF8ToUTF16("")));
+ } else {
+ EXPECT_CALL(*service, GetAuthenticatedUsername())
+ .WillRepeatedly(Return(UTF8ToUTF16("foo")));
+ }
+
+ error->OnStateChanged();
+
+ // If there is an error then a wrench button badge, menu item, and bubble view
+ // should be shown.
+ EXPECT_EQ(error->HasBadge(), is_error);
+ EXPECT_EQ(error->HasMenuItem() || error->HasCustomizedSyncMenuItem(),
+ is_error);
+ EXPECT_EQ(error->HasBubbleView(), is_error);
+
+ // If there is an error then labels should not be empty.
+ EXPECT_NE(error->MenuItemCommandID(), 0);
+ EXPECT_NE(error->MenuItemLabel().empty(), is_error);
+ EXPECT_NE(error->GetBubbleViewAcceptButtonLabel().empty(), is_error);
+
+ // We never have a cancel button.
+ EXPECT_TRUE(error->GetBubbleViewCancelButtonLabel().empty());
+ // We always return a hardcoded title.
+ EXPECT_FALSE(error->GetBubbleViewTitle().empty());
+
+ // Test message handler.
+ if (is_error) {
+ EXPECT_CALL(*service, ShowErrorUI());
+ error->ExecuteMenuItem(NULL);
+ EXPECT_CALL(*service, ShowErrorUI());
+ error->BubbleViewAcceptButtonPressed();
+ error->BubbleViewDidClose();
+ }
+}
+
+} // namespace
+
+// Test that SyncGlobalError shows an error if a passphrase is required.
+TEST(SyncGlobalErrorTest, PassphraseGlobalError) {
+ MessageLoopForUI message_loop;
+ BrowserThread ui_thread(BrowserThread::UI, &message_loop);
+ NiceMock<ProfileSyncServiceMock> service;
+ SyncGlobalError error(&service);
+
+ EXPECT_CALL(service, IsPassphraseRequired())
+ .WillRepeatedly(Return(true));
+ EXPECT_CALL(service, IsPassphraseRequiredForDecryption())
+ .WillRepeatedly(Return(true));
+ VerifySyncGlobalErrorResult(
+ &service, &error, GoogleServiceAuthError::NONE, true, true);
+}
+
+// Test that SyncGlobalError shows an error for conditions that can be resolved
+// by the user and suppresses errors for conditions that cannot be resolved by
+// the user.
+TEST(SyncGlobalErrorTest, AuthStateGlobalError) {
+ MessageLoopForUI message_loop;
+ BrowserThread ui_thread(BrowserThread::UI, &message_loop);
+ NiceMock<ProfileSyncServiceMock> service;
+ SyncGlobalError error(&service);
+
+ browser_sync::SyncBackendHost::Status status;
+ EXPECT_CALL(service, QueryDetailedSyncStatus())
+ .WillRepeatedly(Return(status));
+
+ struct {
+ GoogleServiceAuthError::State error_state;
+ bool is_error;
+ } table[] = {
+ { GoogleServiceAuthError::NONE, false },
+ { GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS, true },
+ { GoogleServiceAuthError::USER_NOT_SIGNED_UP, true },
+ { GoogleServiceAuthError::CONNECTION_FAILED, false },
+ { GoogleServiceAuthError::CAPTCHA_REQUIRED, true },
+ { GoogleServiceAuthError::ACCOUNT_DELETED, true },
+ { GoogleServiceAuthError::ACCOUNT_DISABLED, true },
+ { GoogleServiceAuthError::SERVICE_UNAVAILABLE, true },
+ { GoogleServiceAuthError::TWO_FACTOR, true },
+ { GoogleServiceAuthError::REQUEST_CANCELED, true },
+ { GoogleServiceAuthError::HOSTED_NOT_ALLOWED, true },
+ };
+
+ for (size_t i = 0; i < sizeof(table)/sizeof(*table); ++i) {
+ VerifySyncGlobalErrorResult(
+ &service, &error, table[i].error_state, true, table[i].is_error);
+ VerifySyncGlobalErrorResult(
+ &service, &error, table[i].error_state, false, false);
+ }
+}
« no previous file with comments | « chrome/browser/sync/sync_global_error.cc ('k') | chrome/browser/sync/sync_ui_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698