Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 8308003: Revert 105661 - Revert 105659 - Delay network requests on startup if any webRequest or webNavigat... (Closed)

Created:
9 years, 2 months ago by Pam (message me for reviews)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 105661 - Revert 105659 - Delay network requests on startup if any webRequest or webNavigation extensions are enabled. [Relanding 105659. This will re-cause failures in chrome_frame_net_tests, to be fixed in the next CL.] Add a webRequest extension API permission, used to tell when an extension uses that API and therefore wants to delay startup. Use the "tabs" warning for it. Also clean up the UserScriptListener, which never released requests individually and so doesn't need to track them individually either, and makes the RequestQueue handle bulk releases by its delegates instead. BUG=99450 TEST=unit_tests.exe --gtest_filter=NetworkDelayListenerTest.* Review URL: http://codereview.chromium.org/8205001 TBR=pam@chromium.org Review URL: http://codereview.chromium.org/8296017 TBR=pam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -58 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_time_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/extensions/network_delay_listener.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/network_delay_listener.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 10 chunks +11 lines, -19 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/resource_queue.h View 2 chunks +5 lines, -7 lines 0 comments Download
M content/browser/renderer_host/resource_queue.cc View 1 chunk +13 lines, -9 lines 0 comments Download
M content/browser/renderer_host/resource_queue_unittest.cc View 4 chunks +28 lines, -10 lines 0 comments Download
M net/url_request/url_request.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Pam (message me for reviews)
9 years, 2 months ago (2011-10-15 22:08:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698