Issue 8306025: Disallow function declarations in statement positions in harmony mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8306025: Disallow function declarations in statement positions in harmony mode. (Closed)

Created:
9 years, 2 months ago by Steven

Modified:
9 years, 2 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Disallow function declarations in statement positions in harmony mode. Committed: http://code.google.com/p/v8/source/detail?r=9657

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -18 lines)			Patch
	M	src/parser.cc	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	test/mjsunit/harmony/block-let-declaration.js	View		1 chunk	+8 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Steven

Disallowing for (..) function foo {} in harmony mode. Please take a look. This is ...

9 years, 2 months ago (2011-10-17 10:58:57 UTC) #1

Lasse Reichstein

LGTM http://codereview.chromium.org/8306025/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/8306025/diff/1/src/parser.cc#newcode1337 src/parser.cc:1337: if (top_scope_->is_strict_mode() || harmony_scoping_) { Ditto for the ...

9 years, 2 months ago (2011-10-17 11:31:45 UTC) #2

Steven

9 years, 2 months ago (2011-10-17 11:57:22 UTC) #3

http://codereview.chromium.org/8306025/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/8306025/diff/1/src/parser.cc#newcode1337
src/parser.cc:1337: if (top_scope_->is_strict_mode() || harmony_scoping_) {
Oops, indeed. Done.
On 2011/10/17 11:31:45, Lasse Reichstein wrote:
> Ditto for the preparser?

Expand Messages | Collapse Messages