Make native syntax an early error in the preparser.

Make native syntax an early error in the preparser.

Previously the preparser always accepted natives syntax and let the
real parser throw the syntax error. In ES5, it should be an early error,
so the preparser must catch the error.
The perparser library does not expose parsing for natives syntax, it's
only used internally.

Committed: http://code.google.com/p/v8/source/detail?r=9660

[fschneider, 2011-10-17 10:33:51]

http://codereview.chromium.org/8306024/diff/1/src/parser.h
File src/parser.h (right):

http://codereview.chromium.org/8306024/diff/1/src/parser.h#newcode165
src/parser.h:165: kHarmonyScoping = kAllowNativesSyntax * 2
Why is there not harmony scoping flag in the preparser?

[Lasse Reichstein, 2011-10-17 11:00:30]

http://codereview.chromium.org/8306024/diff/1/src/parser.h
File src/parser.h (right):

http://codereview.chromium.org/8306024/diff/1/src/parser.h#newcode165
src/parser.h:165: kHarmonyScoping = kAllowNativesSyntax * 2
Not sure there is a reason. In the preparser, the parser gets the
harmony-scoping bool from the scanner, so it doesn't need an extra flag.

[Steven, 2011-10-17 11:13:54]

Yes indeed, at the moment the preparser gets the information from the scanner.
But this will need some cleanup soon. According to the draft the switching
between the modes will be more fine grained than one global switch, i.e. it will
be possible to mix classic mode / strict mode / harmony mode (called 'extended'
mode according to the spec) in one source file. In that sense the (pre)parser
should keep track of harmony mode in the same way strict mode is handled now. It
is unfortunate that also the scanner depends on the mode.

On 2011/10/17 11:00:30, Lasse Reichstein wrote:
> http://codereview.chromium.org/8306024/diff/1/src/parser.h
> File src/parser.h (right):
> 
> http://codereview.chromium.org/8306024/diff/1/src/parser.h#newcode165
> src/parser.h:165: kHarmonyScoping = kAllowNativesSyntax * 2
> Not sure there is a reason. In the preparser, the parser gets the
> harmony-scoping bool from the scanner, so it doesn't need an extra flag.

[Lasse Reichstein, 2011-10-17 12:40:30]

Moved the enum, please check again.

[fschneider, 2011-10-17 12:42:38]

lgtm