Issue 8305012: Remove deprecated WebClipboard::readHTML method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8305012: Remove deprecated WebClipboard::readHTML method. (Closed)

Created:
9 years, 2 months ago by dcheng

Modified:
9 years, 2 months ago

Reviewers:
tony

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

Remove deprecated WebClipboard::readHTML method. Now that WebKit r97497 is rolled into Chromium, we no longer need the legacy interface. As a bonus, the last of the Clipboard::readHTML crashes should be fixed. BUG=19360 TEST=ui_unittests and WebKit layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105611

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -39 lines)			Patch
M	ui/base/clipboard/clipboard_win.cc	View	1	1 chunk	+16 lines, -11 lines	0 comments	Download
M	webkit/glue/webclipboard_impl.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/glue/webclipboard_impl.cc	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	webkit/tools/test_shell/mock_webclipboard_impl.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/mock_webclipboard_impl.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

9 years, 2 months ago (2011-10-14 23:11:40 UTC) #2

lgtm

http://codereview.chromium.org/8305012/diff/1/ui/base/clipboard/clipboard_win.cc
File ui/base/clipboard/clipboard_win.cc (right):

http://codereview.chromium.org/8305012/diff/1/ui/base/clipboard/clipboard_win...
ui/base/clipboard/clipboard_win.cc:464: DCHECK((end_index - html_start) <=
kuint32max);
Do we also need to check that start_index - html_start > 0 and end_index -
html_start > 0?

Expand Messages | Collapse Messages