Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: scripts/master/factory/chromeos_factory.py

Issue 8305010: Add ChromiumOS Trybot support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/master/cros_try_job_git.py ('k') | scripts/master/try_job_base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/chromeos_factory.py
===================================================================
--- scripts/master/factory/chromeos_factory.py (revision 105558)
+++ scripts/master/factory/chromeos_factory.py (working copy)
@@ -57,7 +57,7 @@
crostools_repo=_default_crostools,
chromite_repo=_default_chromite,
dry_run=False, chrome_root=None, factory=None,
- slave_manager=True, chromite_patch=None):
+ slave_manager=True, chromite_patch=None, trybot=False):
self.buildroot = buildroot
self.crostools_repo = crostools_repo
self.chromite_repo = chromite_repo
@@ -73,6 +73,7 @@
self.dry_run = dry_run
self.chrome_root = chrome_root
self.slave_manager = slave_manager
+ self.trybot = trybot
if factory:
self.f_cbuild = factory
@@ -239,7 +240,7 @@
if pass_revision:
cbuild_cmd.append(shell.WithProperties('--chrome_version=%(revision)s'))
- if self._branchAtOrAbove('0.12'):
+ if self._branchAtOrAbove('0.12') and not self.trybot:
cbuild_cmd += ['--buildbot']
if self.dry_run:
@@ -255,6 +256,8 @@
# a typo.
cbuild_cmd.append(WithProperties('%s', 'clobber:+--clobber'))
+ cbuild_cmd.append(WithProperties("--gerrit-patches='%(gerrit_patches)s'"))
Peter Mayo 2011/10/15 00:57:42 I suggest guarding this with if self.trybot I don
+
name = self.type
if description_suffix:
description = '%s_%s' % (name, description_suffix)
« no previous file with comments | « scripts/master/cros_try_job_git.py ('k') | scripts/master/try_job_base.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698