Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/master/try_job_base.py

Issue 8305010: Add ChromiumOS Trybot support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« masters/master.tryserver.chromiumos/master.cfg ('K') | « scripts/master/factory/chromeos_factory.py ('k') | scripts/master/try_job_base_bb7.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/try_job_base.py
===================================================================
--- scripts/master/try_job_base.py (revision 105558)
+++ scripts/master/try_job_base.py (working copy)
@@ -55,7 +55,7 @@
options.setdefault('patch', None)
options.setdefault('root', None)
- options.setdefault('clobber', False)
+ options.setdefault('clobber', None)
rcui1 2011/10/14 23:09:28 Default clobber to None (the old behavior) since C
# -pN argument to patch.
options['patchlevel'] = int(options.get('patchlevel', 0))
options.setdefault('branch', None)
@@ -90,7 +90,8 @@
# TODO(maruel): BROKEN ON BULDBOT 0.8.4p1
# pylint: disable=E1101
props.updateFromProperties(self.properties)
- props.setProperty('clobber', options['clobber'], 'Scheduler')
+ if options['clobber'] is not None:
+ props.setProperty('clobber', options['clobber'], 'Scheduler')
if options['testfilter']:
props.setProperty('testfilters', options['testfilter'], 'Scheduler')
return props
« masters/master.tryserver.chromiumos/master.cfg ('K') | « scripts/master/factory/chromeos_factory.py ('k') | scripts/master/try_job_base_bb7.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698