Improve speed of Utf8Write by always flattening the string first and

src/api.cc

Index: src/api.cc
===================================================================
--- src/api.cc	(revision 9640)
+++ src/api.cc	(working copy)
@@ -3634,13 +3634,25 @@
   if (IsDeadCheck(isolate, "v8::String::WriteUtf8()")) return 0;
   LOG_API(isolate, "String::WriteUtf8");
   ENTER_V8(isolate);
+  i::Handle<i::String> str = Utils::OpenHandle(this);
+  if (str->IsAsciiRepresentation()) {

[Yang, 2011/10/17 09:40:51]

IsAsciiRepresentation() is not reliable for cons and slices with regard to
external strings. For example, when a cons is constructed from two ascii
strings, and those two ascii strings are then externalized and converted to
two-byte, the instance type of the cons string still says that it's an ascii
string, which is what  IsAsciiRepresentation() returns.
Use IsAsciiRepresentationUnderneath() instead.

[Erik Corry, 2011/10/17 12:39:09]

I added a test to verify that this is OK.

+    if (capacity == -1) capacity = str->length() + 1;
+    int len = i::Min(capacity, str->length());
+    i::String::WriteToFlat(*str, buffer, 0, len);
+    if (nchars_ref != NULL) *nchars_ref = len;
+    if (!(options & NO_NULL_TERMINATION) && capacity > len) {
+      buffer[len] = '\0';
+      return len + 1;
+    }
+    return len;
+  }
+
   i::StringInputBuffer& write_input_buffer = *isolate->write_input_buffer();
-  i::Handle<i::String> str = Utils::OpenHandle(this);
   isolate->string_tracker()->RecordWrite(str);
   if (options & HINT_MANY_WRITES_EXPECTED) {
     // Flatten the string for efficiency.  This applies whether we are
     // using StringInputBuffer or Get(i) to access the characters.
-    str->TryFlatten();
+    FlattenString(str);
   }
   write_input_buffer.Reset(0, *str);
   int len = str->length();