Issue 8304020: Fix Valgrind warnings from r105646.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8304020: Fix Valgrind warnings from r105646. (Closed)

Created:
9 years, 2 months ago by ddorwin

Modified:
9 years, 2 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix Valgrind warnings from r105646. TBR=scherkus@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105647

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	media/filters/ffmpeg_demuxer_unittest.cc	View		3 chunks	+8 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

mind changing this? http://codereview.chromium.org/8304020/diff/1/media/filters/ffmpeg_demuxer_unittest.cc File media/filters/ffmpeg_demuxer_unittest.cc (right): http://codereview.chromium.org/8304020/diff/1/media/filters/ffmpeg_demuxer_unittest.cc#newcode410 media/filters/ffmpeg_demuxer_unittest.cc:410: EXPECT_CALL(*callback, Run(IsEndOfStreamBuffer())) Woah -- we shouldn't ...

9 years, 2 months ago (2011-10-17 17:59:18 UTC) #1

Corrected in http://codereview.chromium.org/8319010/.

Expand Messages | Collapse Messages