Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1908)

Unified Diff: chrome/browser/ui/browser.cc

Issue 8304018: Make escape exit tabbed fullscreen mode even if browser was in fullscreen mode before. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add bug comment Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index e1b9c58f35c53810d28882f502a2d578e9c4d3d9..94070b0b78bbfbec05489c4f0d614f61b8f0386c 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -3700,6 +3700,12 @@ void Browser::ViewSourceForFrame(TabContents* source,
bool Browser::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
bool* is_keyboard_shortcut) {
+ // Escape exits tabbed fullscreen mode.
+ // TODO(koz): Write a test for this http://crbug.com/100441.
+ if (event.windowsKeyCode == 27 && fullscreened_tab_) {
+ ExitTabbedFullscreenModeIfNecessary();
+ return true;
+ }
return window()->PreHandleKeyboardEvent(event, is_keyboard_shortcut);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698