Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 8304018: Make escape exit tabbed fullscreen mode even if browser was in fullscreen mode before. (Closed)

Created:
9 years, 2 months ago by koz (OOO until 15th September)
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make escape exit tabbed fullscreen mode even if browser was in fullscreen mode before. BUG=89208 TEST=Enter browser fullscreen mode, then tabbed fullscreen mode - escape should return to browser fullscreen mode. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105648

Patch Set 1 #

Patch Set 2 : add bug comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/browser.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
koz (OOO until 15th September)
9 years, 2 months ago (2011-10-15 03:58:55 UTC) #1
yzshen1
lgtm
9 years, 2 months ago (2011-10-15 04:02:38 UTC) #2
yzshen1
lgtm lgtm
9 years, 2 months ago (2011-10-15 04:02:39 UTC) #3
Nico
uh, why not just upload an updated patch set to http://codereview.chromium.org/8301020/ ? Please file a ...
9 years, 2 months ago (2011-10-15 04:02:42 UTC) #4
koz (OOO until 15th September)
On 2011/10/15 04:02:42, Nico wrote: > uh, why not just upload an updated patch set ...
9 years, 2 months ago (2011-10-15 04:19:39 UTC) #5
Nico
9 years, 2 months ago (2011-10-15 04:21:17 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698