Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Side by Side Diff: scripts/master/factory/chromeos_factory.py

Issue 8304016: Only add --gerrit-patches argument or trybot runs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Set of utilities to build the chromium master.""" 5 """Set of utilities to build the chromium master."""
6 6
7 import os 7 import os
8 import re 8 import re
9 9
10 from buildbot.steps import trigger, shell 10 from buildbot.steps import trigger, shell
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 cbuild_cmd += ['--buildroot=%s' % self.buildroot] 249 cbuild_cmd += ['--buildroot=%s' % self.buildroot]
250 cbuild_cmd += [('--revisionfile=%s' % 250 cbuild_cmd += [('--revisionfile=%s' %
251 chromeos_revision_source.PFQ_REVISION_FILE)] 251 chromeos_revision_source.PFQ_REVISION_FILE)]
252 # Below, WithProperties is appended to cbuild_cmd and rendered into a string 252 # Below, WithProperties is appended to cbuild_cmd and rendered into a string
253 # for each specific build at build-time. When clobber is None, it renders 253 # for each specific build at build-time. When clobber is None, it renders
254 # to an empty string. When clobber is not None, it renders to the string 254 # to an empty string. When clobber is not None, it renders to the string
255 # --clobber. Note: the :+ after clobber controls this behavior and is not 255 # --clobber. Note: the :+ after clobber controls this behavior and is not
256 # a typo. 256 # a typo.
257 cbuild_cmd.append(WithProperties('%s', 'clobber:+--clobber')) 257 cbuild_cmd.append(WithProperties('%s', 'clobber:+--clobber'))
258 258
259 cbuild_cmd.append(WithProperties("--gerrit-patches='%(gerrit_patches)s'")) 259 if self.trybot:
260 cbuild_cmd.append(WithProperties("--gerrit-patches='%(gerrit_patches)s'"))
260 261
261 name = self.type 262 name = self.type
262 if description_suffix: 263 if description_suffix:
263 description = '%s_%s' % (name, description_suffix) 264 description = '%s_%s' % (name, description_suffix)
264 else: 265 else:
265 description = name 266 description = name
266 267
267 if self.chrome_root: 268 if self.chrome_root:
268 cbuild_cmd.append('--chrome_root=%s' % self.chrome_root) 269 cbuild_cmd.append('--chrome_root=%s' % self.chrome_root)
269 270
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 chromite_patch=chromite_patch) 378 chromite_patch=chromite_patch)
378 # TODO(sosa): Remove legacy support. 379 # TODO(sosa): Remove legacy support.
379 if chrome_rev_stages: 380 if chrome_rev_stages:
380 for chrome_rev in chrome_rev_stages: 381 for chrome_rev in chrome_rev_stages:
381 bot_params = '--chrome_rev=%s %s' % (chrome_rev, params) 382 bot_params = '--chrome_rev=%s %s' % (chrome_rev, params)
382 self.cbuildbot_type(bot_params, description_suffix=chrome_rev, 383 self.cbuildbot_type(bot_params, description_suffix=chrome_rev,
383 pass_revision=pass_revision, haltOnFailure=False) 384 pass_revision=pass_revision, haltOnFailure=False)
384 else: 385 else:
385 self.cbuildbot_type(params, haltOnFailure=False, 386 self.cbuildbot_type(params, haltOnFailure=False,
386 pass_revision=pass_revision) 387 pass_revision=pass_revision)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698