Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 8302022: Fix pyauto functional tests on chromeos (Closed)

Created:
9 years, 2 months ago by Nirnimesh
Modified:
9 years, 2 months ago
Reviewers:
rohitbm
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Fix pyauto functional tests on chromeos When the unittest module loads TestCases, it loads all attributes that begin with 'test', even the ones that are not functions. Fix it. Also, private member vars should be prefixed by _. TBR=rohitbm@chromium.org R=rohitbm@chromium.org BUG= TEST=desktopui_PyAutoFunctionalTests runs on chromeos Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/test/functional/netflix.py View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nirnimesh
9 years, 2 months ago (2011-10-15 07:33:23 UTC) #1
rohitbm
9 years, 2 months ago (2011-10-17 15:58:17 UTC) #2
On 2011/10/15 07:33:23, Nirnimesh wrote:

LGTM

Powered by Google App Engine
This is Rietveld 408576698