Recommit fraudulent certificate reporting infrastructure.

chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

Index: chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc
===================================================================
--- chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc	(revision 0)
+++ chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc	(revision 0)
@@ -0,0 +1,201 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/net/chrome_fraudulent_certificate_reporter.h"
+
+#include <string>
+
+#include "base/bind.h"
+#include "base/file_path.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop.h"
+#include "base/synchronization/waitable_event.h"
+#include "base/threading/thread.h"
+#include "chrome/browser/net/chrome_url_request_context.h"
+#include "content/browser/browser_thread.h"
+#include "net/base/cert_test_util.h"
+#include "net/base/ssl_info.h"
+#include "net/base/transport_security_state.h"
+#include "net/base/x509_certificate.h"
+#include "net/url_request/fraudulent_certificate_reporter.h"
+#include "net/url_request/url_request.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using net::SSLInfo;
+
+namespace chrome_browser_net {
+
+// Builds an SSLInfo from an invalid cert chain. In this case, the cert is
+// expired; what matters is that the cert would not pass even a normal
+// sanity check. We test that we DO NOT send a fraudulent certificate report
+// in this case.
+static SSLInfo GetBadSSLInfo() {
+  SSLInfo info;
+
+  info.cert = net::ImportCertFromFile(net::GetTestCertsDirectory(),
+                                      "expired_cert.pem");
+  info.is_issued_by_known_root = false;
+
+  return info;
+}
+
+// Builds an SSLInfo from a "good" cert chain, as defined by IsGoodSSLInfo,
+// but which does not pass DomainState::IsChainOfPublicKeysPermitted. In this
+// case, the certificate is for mail.google.com, signed by our Chrome test
+// CA. During testing, Chrome believes this CA is part of the root system
+// store. But, this CA is not in the pin list; we test that we DO send a
+// fraudulent certicate report in this case.
+static SSLInfo GetGoodSSLInfo() {
+  SSLInfo info;
+
+  info.cert = net::ImportCertFromFile(net::GetTestCertsDirectory(),
+                                      "test_mail_google_com.pem");
+  info.is_issued_by_known_root = true;
+
+  return info;
+}
+
+// Checks that |info| is good as required by the SSL checks performed in
+// URLRequestHttpJob::OnStartCompleted, which are enough to trigger pin
+// checking but not sufficient to pass
+// DomainState::IsChainOfPublicKeysPermitted.
+static bool IsGoodSSLInfo(const SSLInfo& info) {
+  return info.is_valid() && info.is_issued_by_known_root;
+}
+
+class TestReporter : public ChromeFraudulentCertificateReporter {
+ public:
+  explicit TestReporter(net::URLRequestContext* request_context)
+      : ChromeFraudulentCertificateReporter(request_context) {}
+};
+
+class SendingTestReporter : public TestReporter {
+ public:
+  explicit SendingTestReporter(net::URLRequestContext* request_context)
+      : TestReporter(request_context), passed_(false) {}
+
+  // Passes if invoked with a good SSLInfo and for a hostname that is a Google
+  // pinned property.
+  virtual void SendReport(const std::string& hostname,
+                          const SSLInfo& ssl_info,
+                          bool sni_available) OVERRIDE {
+    EXPECT_TRUE(IsGoodSSLInfo(ssl_info));
+    EXPECT_TRUE(net::TransportSecurityState::IsGooglePinnedProperty(
+        hostname, sni_available));
+    passed_ = true;
+  }
+
+  virtual ~SendingTestReporter() {
+    // If the object is destroyed without having its SendReport method invoked,
+    // we failed.
+    EXPECT_TRUE(passed_);
+  }
+
+  bool passed_;
+};
+
+class NotSendingTestReporter : public TestReporter {
+ public:
+  explicit NotSendingTestReporter(net::URLRequestContext* request_context)
+      : TestReporter(request_context) {}
+
+  // Passes if invoked with a bad SSLInfo and for a hostname that is not a
+  // Google pinned property.
+  virtual void SendReport(const std::string& hostname,
+                          const SSLInfo& ssl_info,
+                          bool sni_available) OVERRIDE {
+    EXPECT_FALSE(IsGoodSSLInfo(ssl_info));
+    EXPECT_FALSE(net::TransportSecurityState::IsGooglePinnedProperty(
+        hostname, sni_available));
+  }
+};
+
+// For the first version of the feature, sending reports is "fire and forget".
+// Therefore, we test only that the Reporter tried to send a request at all.
+// In the future, when we have more sophisticated (i.e., any) error handling
+// and re-tries, we will need more sopisticated tests as well.
+//
+// This class doesn't do anything now, but in near future versions it will.
+class MockURLRequest : public net::URLRequest {
+ public:
+  MockURLRequest() : net::URLRequest(GURL(""), NULL), passed_(false) {
+  }
+
+ private:
+  bool passed_;
+};
+
+// A ChromeFraudulentCertificateReporter that uses a MockURLRequest, but is
+// otherwise normal: reports are constructed and sent in the usual way.
+class MockReporter : public ChromeFraudulentCertificateReporter {
+ public:
+  explicit MockReporter(net::URLRequestContext* request_context)
+    : ChromeFraudulentCertificateReporter(request_context) {}
+
+  virtual net::URLRequest* CreateURLRequest() OVERRIDE {
+    return new MockURLRequest();
+  }
+
+  virtual void SendReport(
+      const std::string& hostname,
+      const net::SSLInfo& ssl_info,
+      bool sni_available) {
+    DCHECK(!hostname.empty());
+    DCHECK(ssl_info.is_valid());
+    ChromeFraudulentCertificateReporter::SendReport(hostname, ssl_info, sni_available);
+  }
+};
+
+static void DoReportIsSent() {
+  scoped_refptr<ChromeURLRequestContext> context = new ChromeURLRequestContext;
+  SendingTestReporter reporter(context.get());
+  SSLInfo info = GetGoodSSLInfo();
+  reporter.SendReport("mail.google.com", info, true);
+}
+
+static void DoReportIsNotSent() {
+  scoped_refptr<ChromeURLRequestContext> context = new ChromeURLRequestContext;
+  NotSendingTestReporter reporter(context.get());
+  SSLInfo info = GetBadSSLInfo();
+  reporter.SendReport("127.0.0.1", info, true);
+}
+
+static void DoMockReportIsSent() {
+  scoped_refptr<ChromeURLRequestContext> context = new ChromeURLRequestContext;
+  MockReporter reporter(context.get());
+  SSLInfo info = GetGoodSSLInfo();
+  reporter.SendReport("mail.google.com", info, true);
+}
+
+TEST(ChromeFraudulentCertificateReporterTest, GoodBadInfo) {
+  SSLInfo good = GetGoodSSLInfo();
+  EXPECT_TRUE(IsGoodSSLInfo(good));
+
+  SSLInfo bad = GetBadSSLInfo();
+  EXPECT_FALSE(IsGoodSSLInfo(bad));
+}
+
+TEST(ChromeFraudulentCertificateReporterTest, ReportIsSent) {
+  MessageLoop loop(MessageLoop::TYPE_IO);
+  BrowserThread io_thread(BrowserThread::IO, &loop);
+  loop.PostTask(FROM_HERE, base::Bind(&DoReportIsSent));
+  loop.RunAllPending();
+}
+
+TEST(ChromeFraudulentCertificateReporterTest, MockReportIsSent) {
+  MessageLoop loop(MessageLoop::TYPE_IO);
+  BrowserThread io_thread(BrowserThread::IO, &loop);
+  loop.PostTask(FROM_HERE, base::Bind(&DoMockReportIsSent));
+  loop.RunAllPending();
+}
+
+TEST(ChromeFraudulentCertificateReporterTest, ReportIsNotSent) {
+  MessageLoop loop(MessageLoop::TYPE_IO);
+  BrowserThread io_thread(BrowserThread::IO, &loop);
+  loop.PostTask(FROM_HERE, base::Bind(&DoReportIsNotSent));
+  loop.RunAllPending();
+}
+
+}  // namespace chrome_browser_net
+