Issue 8302018: Make content_shell not crash on startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8302018: Make content_shell not crash on startup. (Closed)

Created:
9 years, 2 months ago by jam

Modified:
9 years, 2 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make content_shell not crash on startup. BUG=100422 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105665

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -79 lines)			Patch
	M	content/shell/shell_url_request_context_getter.h	View		2 chunks	+3 lines, -19 lines	0 comments	Download
	M	content/shell/shell_url_request_context_getter.cc	View		4 chunks	+47 lines, -60 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

I wonder if we want to reuse TestShellRequestContext in content_shell?

9 years, 2 months ago (2011-10-15 01:03:26 UTC) #1

jam

On 2011/10/15 01:03:26, John Abd-El-Malek wrote: > I wonder if we want to reuse TestShellRequestContext ...

9 years, 2 months ago (2011-10-15 01:25:12 UTC) #2

willchan no longer on Chromium

9 years, 2 months ago (2011-10-15 08:25:36 UTC) #3

lgtm

http://codereview.chromium.org/8302018/diff/1/content/shell/shell_url_request...
File content/shell/shell_url_request_context_getter.cc (right):

http://codereview.chromium.org/8302018/diff/1/content/shell/shell_url_request...
content/shell/shell_url_request_context_getter.cc:51:
scoped_ptr<net::ProxyConfigService>  proxy_config_service(
One too many whitespaces between the type and the variable name?

Expand Messages | Collapse Messages