Make GTK and Aura parts orthogonal to OS parts

content/browser/browser_main_loop.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
+#define CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
+#pragma once
+
+#include "base/basictypes.h"
+#include "base/command_line.h"

[jam, 2011/10/25 06:11:28]

nit: most of these headers aren't referenced in this file. just forward declare
MainFunctionParams

[stevenjb, 2011/10/25 19:21:18]

Done.

+#include "base/message_loop.h"
+#include "base/system_monitor/system_monitor.h"
+#include "content/browser/browser_thread.h"
+#include "content/common/hi_res_timer_manager.h"
+#include "content/common/main_function_params.h"
+#include "net/base/network_change_notifier.h"
+
+namespace content {
+
+// Implements the main browser loop stages called from |BrowserMain()|.
+// See comments in browser_main_parts.h for additional info.
+class BrowserMainLoop {

[jam, 2011/10/25 06:11:28]

sorry maybe I wasn't clear. I had meant just putting the class definition in
this file. i don't think we need to add an interface and implement it in the cc
file. BrowserMain can instantiate the BrowserMainLoop object directly

[stevenjb, 2011/10/25 16:24:34]

I generally prefer to keep implementation details out of the header as much as
possible. I can wrap the Impl calls instead of using a static method to create
the implementation class if you prefer that?

[jam, 2011/10/25 16:33:59]

hmm I haven't encountered this anywhere else in chrome code (although I haven't
looked closely at cros code). I'm hesitant of starting to use this pattern. When
someone is looking at the header, it's clear which are public methods, and where
the implementation is. Why should this class be treated special?

also, part of the reason for splitting content from chrome is to make embedders
see less code. This class will be entirely in the implementation part (i.e.
content/src) and won't be visible in the API dir (content/public).

[stevenjb, 2011/10/25 19:21:18]

OK, I will change this.

+ public:
+  static BrowserMainLoop* CreateInstance(
+      const MainFunctionParams& parameters);
+
+  BrowserMainLoop() {}
+  virtual ~BrowserMainLoop() {}
+
+  // Parts to be called by |BrowserMain()|.
+  virtual void EarlyInitialization() = 0;
+  virtual void InitializeToolkit() = 0;
+  virtual void MainMessageLoopStart() = 0;
+  virtual void RunMainMessageLoopParts(
+      bool* completed_main_message_loop) = 0;
+  virtual void MainMessageLoopRun() = 0;
+
+  virtual int GetResultCode() const = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BrowserMainLoop);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_