Fix memory error in previous CL.

Fix memory error in previous CL.

BUG=100315
BUG=99016
TEST=Memory bots go green

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105577

[Timur Iskhodzhanov, 2011-10-14 17:30:13]

LGTM for the Valgrind part.
14.10.2011 21:10 пользователь <creis@chromium.org> написал:

> Reviewers: Timur Iskhodzhanov, brettw,
>
> Description:
> Fix memory error in previous CL.
>
> BUG=100315
> BUG=99016
> TEST=Memory bots go green
>
>
> Please review this at
http://codereview.chromium.**org/8302001/<http://codereview.chromium.org/8302...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/ui/browser_**navigator.cc
>  M tools/valgrind/memcheck/**suppressions.txt
>
>
> Index: chrome/browser/ui/browser_**navigator.cc
> diff --git a/chrome/browser/ui/browser_**navigator.cc
> b/chrome/browser/ui/browser_**navigator.cc
> index f6bb0938b34e6359501c063431c2b2**ea3662b38b..**
> 1fb028f0117215563170e10e7038f6**8a25cf65e6 100644
> --- a/chrome/browser/ui/browser_**navigator.cc
> +++ b/chrome/browser/ui/browser_**navigator.cc
> @@ -334,6 +334,7 @@ NavigateParams::**NavigateParams(
>       source_contents(NULL),
>       disposition(CURRENT_TAB),
>       transition(a_transition),
> +      is_renderer_initiated(false),
>       tabstrip_index(-1),
>       tabstrip_add_types(**TabStripModel::ADD_ACTIVE),
>       window_action(NO_ACTION),
> @@ -350,6 +351,7 @@ NavigateParams::**NavigateParams(Browser* a_browser,
>       source_contents(NULL),
>       disposition(CURRENT_TAB),
>       transition(content::PAGE_**TRANSITION_LINK),
> +      is_renderer_initiated(false),
>       tabstrip_index(-1),
>       tabstrip_add_types(**TabStripModel::ADD_ACTIVE),
>       window_action(NO_ACTION),
> Index: tools/valgrind/memcheck/**suppressions.txt
> diff --git a/tools/valgrind/memcheck/**suppressions.txt
> b/tools/valgrind/memcheck/**suppressions.txt
> index 1c4f7010175648d14e4f4e0adfce4d**4a3b5c430f..**
> 49745bb8927d151bc661113d744de0**6344cb0565 100644
> --- a/tools/valgrind/memcheck/**suppressions.txt
> +++ b/tools/valgrind/memcheck/**suppressions.txt
> @@ -4718,11 +4718,6 @@
>    fun:_**ZN7WebCore11RenderBlock6layout**Ev
>  }
>  {
> -   bug_100315
> -   Memcheck:Cond
> -   fun:_ZN7browser8NavigateEPNS_**14NavigateParamsE
> -}
> -{
>    bug_100330
>    Memcheck:Leak
>    fun:_Znw*
>
>
>

[brettw, 2011-10-14 17:31:25]

lgtm