Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 8301021: Remove redundant 'escape to quit fullscreen/mouse lock' code. (Closed)

Created:
9 years, 2 months ago by koz (OOO until 15th September)
Modified:
9 years, 2 months ago
Reviewers:
brettw, yzshen1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Remove redundant 'escape to quit fullscreen/mouse lock' code. BUG=41781 TEST=Escape key should still exit mouse lock / tabbed fullscreen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105656

Patch Set 1 #

Total comments: 2

Patch Set 2 : respond to comments #

Total comments: 2

Patch Set 3 : respond to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
koz (OOO until 15th September)
9 years, 2 months ago (2011-10-15 03:14:05 UTC) #1
yzshen1
You may need to add the owner of these files as reviewer, too. http://codereview.chromium.org/8301021/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc File ...
9 years, 2 months ago (2011-10-15 03:25:53 UTC) #2
koz (OOO until 15th September)
http://codereview.chromium.org/8301021/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (left): http://codereview.chromium.org/8301021/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc#oldcode1295 content/browser/renderer_host/render_widget_host_view_win.cc:1295: if (is_fullscreen_) { On 2011/10/15 03:25:53, yzshen1 wrote: > ...
9 years, 2 months ago (2011-10-15 04:12:34 UTC) #3
yzshen1
http://codereview.chromium.org/8301021/diff/4001/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): http://codereview.chromium.org/8301021/diff/4001/content/browser/renderer_host/render_widget_host_view_win.cc#newcode1292 content/browser/renderer_host/render_widget_host_view_win.cc:1292: absorbed = true; you could remove |absorbed| and return ...
9 years, 2 months ago (2011-10-15 04:32:30 UTC) #4
koz (OOO until 15th September)
http://codereview.chromium.org/8301021/diff/4001/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): http://codereview.chromium.org/8301021/diff/4001/content/browser/renderer_host/render_widget_host_view_win.cc#newcode1292 content/browser/renderer_host/render_widget_host_view_win.cc:1292: absorbed = true; On 2011/10/15 04:32:30, yzshen1 wrote: > ...
9 years, 2 months ago (2011-10-15 04:36:55 UTC) #5
brettw
lgtm
9 years, 2 months ago (2011-10-15 04:37:00 UTC) #6
yzshen1
9 years, 2 months ago (2011-10-15 04:44:14 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698