Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 8301020: Make escape exit tabbed fullscreen mode. (Closed)

Created:
9 years, 2 months ago by koz (OOO until 15th September)
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make escape exit tabbed fullscreen mode. BUG=89208 TEST=Press escape in tabbed fullscreen mode.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koz (OOO until 15th September)
9 years, 2 months ago (2011-10-15 02:53:57 UTC) #1
Nico
lgtm please add a test for this soonish.
9 years, 2 months ago (2011-10-15 02:55:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/8301020/1
9 years, 2 months ago (2011-10-15 02:58:57 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-15 06:58:28 UTC) #4
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 105645, job name
was 8301020-1 (retry) (retry) (retry) (retry).

Powered by Google App Engine
This is Rietveld 408576698