Packaged (CRX) extensions shouldn't be able to get 'dev' interfaces in NaCl.

ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc

Index: ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc
===================================================================
--- ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc	(revision 105554)
+++ ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc	(working copy)
@@ -50,34 +50,33 @@
 ////////////////////////////////////////////////////////////////////////////////
 
 void TestGetDevInterfaces() {
-  // This test is run only w/ NACL_ENABLE_PPAPI_DEV=0, which should
-  // turn off and disable the PPAPI developer interfaces. When they are
-  // disabled, the interface should return NULL.
-  CHECK(GetBrowserInterface(PPB_BUFFER_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_CHAR_SET_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_CONSOLE_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_CONTEXT_3D_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_CRYPTO_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_CURSOR_CONTROL_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_DIRECTORYREADER_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_FILECHOOSER_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_FIND_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_FONT_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_FULLSCREEN_DEV_INTERFACE) == NULL);
+  // This test is run as a simple embedded .nexe with --enable-nacl. It should
+  // have access to all dev interfaces.

[sehr, 2011/10/14 21:38:32]

Shouldn't we have a corresponding test that these are not available from
appstore nexes?

[bbudge, 2011/10/14 22:03:27]

Yes, but it would be very difficult to set this up in this test. Ideas?
On 2011/10/14 21:38:32, sehr1 wrote:

+  CHECK(GetBrowserInterface(PPB_BUFFER_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_CHAR_SET_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_CONSOLE_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_CONTEXT_3D_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_CRYPTO_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_CURSOR_CONTROL_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_DIRECTORYREADER_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_FILECHOOSER_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_FIND_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_FONT_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_FULLSCREEN_DEV_INTERFACE) != NULL);
   CHECK(GetBrowserInterface(
-      PPB_GLES_CHROMIUM_TEXTURE_MAPPING_DEV_INTERFACE) == NULL);
+      PPB_GLES_CHROMIUM_TEXTURE_MAPPING_DEV_INTERFACE) != NULL);
   CHECK(GetBrowserInterface(PPB_LAYER_COMPOSITOR_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_MEMORY_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_MOUSELOCK_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_SCROLLBAR_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_SURFACE_3D_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_TESTING_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_TRANSPORT_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_URLUTIL_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_VAR_DEPRECATED_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_VIDEODECODER_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_WIDGET_DEV_INTERFACE) == NULL);
-  CHECK(GetBrowserInterface(PPB_ZOOM_DEV_INTERFACE) == NULL);
+  CHECK(GetBrowserInterface(PPB_MEMORY_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_MOUSELOCK_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_SCROLLBAR_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_SURFACE_3D_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_TESTING_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_TRANSPORT_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_URLUTIL_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_VAR_DEPRECATED_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_VIDEODECODER_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_WIDGET_DEV_INTERFACE) != NULL);
+  CHECK(GetBrowserInterface(PPB_ZOOM_DEV_INTERFACE) != NULL);
 
   TEST_PASSED;
 }