ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc - Issue 8301006: Packaged (CRX) extensions shouldn't be able to get 'dev' interfaces in NaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc

Issue 8301006: Packaged (CRX) extensions shouldn't be able to get 'dev' interfaces in NaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc ('k') | ppapi/native_client/src/trusted/plugin/plugin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc

===================================================================

--- ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc (revision 105583)

+++ ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc (working copy)

@@ -16,7 +16,6 @@

#include "ppapi/c/pp_completion_callback.h"

#include "srpcgen/ppb_rpc.h"

-using ppapi_proxy::AreDevInterfacesEnabled;

using ppapi_proxy::DebugPrintf;

using ppapi_proxy::LookupBrowserPppForInstance;

using ppapi_proxy::MakeRemoteCompletionCallback;

@@ -63,8 +62,8 @@

NaClSrpcClosureRunner runner(done);

rpc->result = NACL_SRPC_RESULT_APP_ERROR;

- if (AreDevInterfacesEnabled()) {

- plugin::Plugin* plugin = LookupBrowserPppForInstance(instance)->plugin();

+ plugin::Plugin* plugin = LookupBrowserPppForInstance(instance)->plugin();

+ if (plugin->enable_dev_interfaces()) {

int32_t posix_file_desc = plugin->GetPOSIXFileDesc(url);

DebugPrintf("NaClFile::GetFileDesc: posix_file_desc=%"NACL_PRId32"\n",

posix_file_desc);