Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc

Issue 8301006: Packaged (CRX) extensions shouldn't be able to get 'dev' interfaces in NaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc
===================================================================
--- ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc (revision 105971)
+++ ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc (working copy)
@@ -16,32 +16,8 @@
#include "ppapi/c/pp_errors.h"
#include "ppapi/c/ppb_core.h"
-#include "ppapi/c/dev/ppb_buffer_dev.h"
-#include "ppapi/c/dev/ppb_char_set_dev.h"
-#include "ppapi/c/dev/ppb_console_dev.h"
-#include "ppapi/c/dev/ppb_context_3d_dev.h"
-#include "ppapi/c/dev/ppb_context_3d_trusted_dev.h"
-#include "ppapi/c/dev/ppb_crypto_dev.h"
#include "ppapi/c/dev/ppb_cursor_control_dev.h"
-#include "ppapi/c/dev/ppb_directory_reader_dev.h"
-#include "ppapi/c/dev/ppb_file_chooser_dev.h"
-#include "ppapi/c/dev/ppb_find_dev.h"
-#include "ppapi/c/dev/ppb_font_dev.h"
-#include "ppapi/c/dev/ppb_fullscreen_dev.h"
-#include "ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h"
-#include "ppapi/c/dev/ppb_layer_compositor_dev.h"
-#include "ppapi/c/dev/ppb_memory_dev.h"
-#include "ppapi/c/dev/ppb_scrollbar_dev.h"
-#include "ppapi/c/dev/ppb_surface_3d_dev.h"
-#include "ppapi/c/dev/ppb_testing_dev.h"
-#include "ppapi/c/dev/ppb_transport_dev.h"
-#include "ppapi/c/dev/ppb_url_util_dev.h"
-#include "ppapi/c/dev/ppb_var_deprecated.h"
-#include "ppapi/c/dev/ppb_video_decoder_dev.h"
-#include "ppapi/c/dev/ppb_widget_dev.h"
-#include "ppapi/c/dev/ppb_zoom_dev.h"
-
namespace {
////////////////////////////////////////////////////////////////////////////////
@@ -49,33 +25,10 @@
////////////////////////////////////////////////////////////////////////////////
void TestGetDevInterfaces() {
- // This test is run only w/ NACL_ENABLE_PPAPI_DEV=0, which should
- // turn off and disable the PPAPI developer interfaces. When they are
- // disabled, the interface should return NULL.
- CHECK(GetBrowserInterface(PPB_BUFFER_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_CHAR_SET_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_CONSOLE_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_CONTEXT_3D_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_CRYPTO_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_CURSOR_CONTROL_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_DIRECTORYREADER_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_FILECHOOSER_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_FIND_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_FONT_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_FULLSCREEN_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(
- PPB_GLES_CHROMIUM_TEXTURE_MAPPING_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_LAYER_COMPOSITOR_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_MEMORY_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_SCROLLBAR_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_SURFACE_3D_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_TESTING_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_TRANSPORT_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_URLUTIL_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_VAR_DEPRECATED_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_VIDEODECODER_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_WIDGET_DEV_INTERFACE) == NULL);
- CHECK(GetBrowserInterface(PPB_ZOOM_DEV_INTERFACE) == NULL);
+ // This test is run as a simple embedded .nexe with --enable-nacl. It should
+ // have access to all dev interfaces. Only test one to make the test more
+ // robust as interfaces change.
+ EXPECT(GetBrowserInterface(PPB_CURSOR_CONTROL_DEV_INTERFACE) != NULL);
TEST_PASSED;
}
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/plugin.cc ('k') | ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698